[GitHub] [spark] cloud-fan commented on a diff in pull request #42744: [SPARK-44990][SQL][FOLLOWUP] Add benchmark for write null value to csv

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #42744:
URL: https://github.com/apache/spark/pull/42744#discussion_r1311214577


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVBenchmark.scala:
##########
@@ -378,6 +394,7 @@ object CSVBenchmark extends SqlBasedBenchmark {
       countBenchmark(rowsNum = 10 * 1000 * 1000, numIters)
       datetimeBenchmark(rowsNum = 10 * 1000 * 1000, numIters)
       filtersPushdownBenchmark(rowsNum = 100 * 1000, numIters)
+      writeNullBenchmark(rowsNum = 10 * 1000 * 1000, numIters)

Review Comment:
   it isn't worth adding benchmark for writing all null values...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org