[GitHub] [flink] tillrohrmann commented on a change in pull request #9809: [FLINK-14282] Simplify DispatcherResourceManagerComponent hierarchy

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #9809: [FLINK-14282] Simplify DispatcherResourceManagerComponent hierarchy
URL: https://github.com/apache/flink/pull/9809#discussion_r329969200
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DefaultDispatcherResourceManagerComponentFactory.java
 ##########
 @@ -71,24 +71,23 @@
 /**
  * Abstract class which implements the creation of the {@link DispatcherResourceManagerComponent} components.
  *
- * @param <T> type of the {@link DispatcherRunner}
  * @param <U> type of the {@link RestfulGateway} given to the {@link WebMonitorEndpoint}
  */
-public abstract class AbstractDispatcherResourceManagerComponentFactory<T extends DispatcherRunner, U extends RestfulGateway> implements DispatcherResourceManagerComponentFactory {
+public class DefaultDispatcherResourceManagerComponentFactory<U extends RestfulGateway> implements DispatcherResourceManagerComponentFactory {
 
 Review comment:
   Why not? The `DefaultDispatcherResourceManagerComponentFactory` has no abstract methods anymore. Moreover, the `JobDispatcherResourceManagerComponentFactory` and `SessionDispatcherResourceManagerComponentFactory` are only used to set the factory up in a certain way. I think they could actually be removed and replaced by some static helper methods. There is no need to have different subclasses for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services