You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/04 11:21:19 UTC
[GitHub] [airflow] XD-DENG opened a new pull request #12085: Remove explicit casting to List when sorted() is applied
XD-DENG opened a new pull request #12085:
URL: https://github.com/apache/airflow/pull/12085
`sorted()` returns a sorted list.
`sorted(list(A))` is equivalent to `sorted(A)` no matter A is *Tuple*, *List*, or *Set*.
Ref: https://docs.python.org/3/library/functions.html#sorted
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12085: Remove explicit casting to List when sorted() is applied
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12085:
URL: https://github.com/apache/airflow/pull/12085#discussion_r517300005
##########
File path: tests/build_provider_packages_dependencies.py
##########
@@ -242,7 +242,7 @@ def insert_documentation(deps_dict: Dict[str, List[str]], res: List[str]):
print(f"Total: {len(errors)} errors.")
unique_sorted_dependencies: Dict[str, List[str]] = {}
for key in sorted(dependencies.keys()):
- unique_sorted_dependencies[key] = sorted(list(set(dependencies[key])))
+ unique_sorted_dependencies[key] = sorted(set(dependencies[key]))
Review comment:
Wait... I think the change is aligned with L243. `sorted()` always returns `List`. Nothing is wrong with the type check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #12085: Remove explicit casting to List when sorted() is applied
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #12085:
URL: https://github.com/apache/airflow/pull/12085
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12085: Remove explicit casting to List when sorted() is applied
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12085:
URL: https://github.com/apache/airflow/pull/12085#discussion_r517293918
##########
File path: tests/build_provider_packages_dependencies.py
##########
@@ -242,7 +242,7 @@ def insert_documentation(deps_dict: Dict[str, List[str]], res: List[str]):
print(f"Total: {len(errors)} errors.")
unique_sorted_dependencies: Dict[str, List[str]] = {}
for key in sorted(dependencies.keys()):
- unique_sorted_dependencies[key] = sorted(list(set(dependencies[key])))
+ unique_sorted_dependencies[key] = sorted(set(dependencies[key]))
Review comment:
It should not fail, given the earlier code `sorted(list(set(dependencies[key])))` is returning a `List` as well.
But I get your point. In such a case, seems the type check here is not working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12085: Remove explicit casting to List when sorted() is applied
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12085:
URL: https://github.com/apache/airflow/pull/12085#issuecomment-721705912
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12085: Remove explicit casting to List when sorted() is applied
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12085:
URL: https://github.com/apache/airflow/pull/12085#discussion_r517277080
##########
File path: tests/build_provider_packages_dependencies.py
##########
@@ -242,7 +242,7 @@ def insert_documentation(deps_dict: Dict[str, List[str]], res: List[str]):
print(f"Total: {len(errors)} errors.")
unique_sorted_dependencies: Dict[str, List[str]] = {}
for key in sorted(dependencies.keys()):
- unique_sorted_dependencies[key] = sorted(list(set(dependencies[key])))
+ unique_sorted_dependencies[key] = sorted(set(dependencies[key]))
Review comment:
This might fail MyPy coz of L243: `unique_sorted_dependencies: Dict[str, List[str]] = {}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12085: Remove explicit casting to List when sorted() is applied
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12085:
URL: https://github.com/apache/airflow/pull/12085#discussion_r517300005
##########
File path: tests/build_provider_packages_dependencies.py
##########
@@ -242,7 +242,7 @@ def insert_documentation(deps_dict: Dict[str, List[str]], res: List[str]):
print(f"Total: {len(errors)} errors.")
unique_sorted_dependencies: Dict[str, List[str]] = {}
for key in sorted(dependencies.keys()):
- unique_sorted_dependencies[key] = sorted(list(set(dependencies[key])))
+ unique_sorted_dependencies[key] = sorted(set(dependencies[key]))
Review comment:
Wait... I think the change is aligned with L243. `sorted()` always returns `List`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org