You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@avalon.apache.org by pr...@apache.org on 2003/04/17 22:46:49 UTC

cvs commit: avalon-excalibur/datasource/src/java/org/apache/avalon/excalibur/datasource AbstractJdbcConnection.java

proyal      2003/04/17 13:46:49

  Modified:    datasource default.properties
               datasource/src/java/org/apache/avalon/excalibur/datasource
                        AbstractJdbcConnection.java
  Log:
  Throw the TargetException, so SQLException's get thrown correctly. DOH!
  
  Revision  Changes    Path
  1.27      +1 -1      avalon-excalibur/datasource/default.properties
  
  Index: default.properties
  ===================================================================
  RCS file: /home/cvs/avalon-excalibur/datasource/default.properties,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- default.properties	7 Apr 2003 18:45:55 -0000	1.26
  +++ default.properties	17 Apr 2003 20:46:49 -0000	1.27
  @@ -8,7 +8,7 @@
   name=excalibur-datasource
   Name=Excalibur Datasource
   dir-name=datasource
  -version=1.1
  +version=1.1a
   package-version=1.0
   year=2000-2002
   
  
  
  
  1.28      +13 -5     avalon-excalibur/datasource/src/java/org/apache/avalon/excalibur/datasource/AbstractJdbcConnection.java
  
  Index: AbstractJdbcConnection.java
  ===================================================================
  RCS file: /home/cvs/avalon-excalibur/datasource/src/java/org/apache/avalon/excalibur/datasource/AbstractJdbcConnection.java,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- AbstractJdbcConnection.java	8 Apr 2003 18:34:33 -0000	1.27
  +++ AbstractJdbcConnection.java	17 Apr 2003 20:46:49 -0000	1.28
  @@ -52,6 +52,7 @@
   import java.lang.reflect.Method;
   import java.lang.reflect.Proxy;
   import java.lang.reflect.InvocationHandler;
  +import java.lang.reflect.InvocationTargetException;
   import java.sql.Connection;
   import java.sql.PreparedStatement;
   import java.sql.ResultSet;
  @@ -345,13 +346,20 @@
           Object retVal = null;
           Method executeMethod = (Method)m_methods.get( method.getName() );
   
  -        if( null == executeMethod )
  +        try
           {
  -            retVal = method.invoke( m_connection, args );
  +            if( null == executeMethod )
  +            {
  +                retVal = method.invoke( m_connection, args );
  +            }
  +            else
  +            {
  +                retVal = executeMethod.invoke( this, args );
  +            }
           }
  -        else
  +        catch( InvocationTargetException e )
           {
  -            retVal = executeMethod.invoke( this, args );
  +            throw e.getTargetException();
           }
   
           return retVal;
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: cvs-unsubscribe@avalon.apache.org
For additional commands, e-mail: cvs-help@avalon.apache.org


Re: cvs commit: avalon-excalibur/datasource/src/java/org/apache/avalon/excalibur/datasource AbstractJdbcConnection.java

Posted by Leo Simons <le...@apache.org>.
what we need is to have successful nightly builds available for download 
(and known to be available for download). Gump to the rescue!!!!

(now to find a volunteer........... ;)

- Leo

Peter Royal wrote:
> On Thursday, April 17, 2003, at 04:46  PM, proyal@apache.org wrote:
> 
>> proyal      2003/04/17 13:46:49
>>
>>   Modified:    datasource default.properties
>>                datasource/src/java/org/apache/avalon/excalibur/datasource
>>                         AbstractJdbcConnection.java
>>   Log:
>>   Throw the TargetException, so SQLException's get thrown correctly. DOH!
> 
> 
> We may want to do a 'brown-paper-bag' release on datasource...
> -pete



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: cvs commit: avalon-excalibur/datasource/src/java/org/apache/avalon/excalibur/datasource AbstractJdbcConnection.java

Posted by Peter Royal <pr...@apache.org>.
On Friday, April 18, 2003, at 08:13  AM, Berin Loritsch wrote:
>>> A 0.0.1 release?  Sure.
>> I already changed the version to 1.1a, but we can goto 1.1.1...
>
> "a" usually is associated with "alpha" which I don't want, and
> "b" usually is associated with "beta" which we don't want either.

ok, i changed to 1.1.1
-pete


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: cvs commit: avalon-excalibur/datasource/src/java/org/apache/avalon/excalibur/datasource AbstractJdbcConnection.java

Posted by Berin Loritsch <bl...@apache.org>.
Peter Royal wrote:
> On Thursday, April 17, 2003, at 04:55  PM, Berin Loritsch wrote:
> 
>> Peter Royal wrote:
>>
>>> On Thursday, April 17, 2003, at 04:46  PM, proyal@apache.org wrote:
>>>
>>>> proyal      2003/04/17 13:46:49
>>>>
>>>>   Modified:    datasource default.properties
>>>>                
>>>> datasource/src/java/org/apache/avalon/excalibur/datasource
>>>>                         AbstractJdbcConnection.java
>>>>   Log:
>>>>   Throw the TargetException, so SQLException's get thrown correctly. 
>>>> DOH!
>>>
>>> We may want to do a 'brown-paper-bag' release on datasource...
>>> -pete
>>
>>
>>
>> A 0.0.1 release?  Sure.
> 
> 
> I already changed the version to 1.1a, but we can goto 1.1.1...

"a" usually is associated with "alpha" which I don't want, and
"b" usually is associated with "beta" which we don't want either.


-- 
"You know the world is going crazy when the best
rapper is a white guy, the best golfer is a black guy,
The Swiss hold the America's Cup, France is
accusing the US of arrogance, and Germany doesn't want
to go to war. And the 3 most powerful men in America
are named 'Bush', 'Dick', and 'Colon' (sic)".

-----Chris Rock


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: cvs commit: avalon-excalibur/datasource/src/java/org/apache/avalon/excalibur/datasource AbstractJdbcConnection.java

Posted by Peter Royal <pr...@apache.org>.
On Thursday, April 17, 2003, at 04:55  PM, Berin Loritsch wrote:
> Peter Royal wrote:
>> On Thursday, April 17, 2003, at 04:46  PM, proyal@apache.org wrote:
>>> proyal      2003/04/17 13:46:49
>>>
>>>   Modified:    datasource default.properties
>>>                
>>> datasource/src/java/org/apache/avalon/excalibur/datasource
>>>                         AbstractJdbcConnection.java
>>>   Log:
>>>   Throw the TargetException, so SQLException's get thrown correctly. 
>>> DOH!
>> We may want to do a 'brown-paper-bag' release on datasource...
>> -pete
>
>
> A 0.0.1 release?  Sure.

I already changed the version to 1.1a, but we can goto 1.1.1...
-pete


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: cvs commit: avalon-excalibur/datasource/src/java/org/apache/avalon/excalibur/datasource AbstractJdbcConnection.java

Posted by Berin Loritsch <bl...@apache.org>.
Peter Royal wrote:
> On Thursday, April 17, 2003, at 04:46  PM, proyal@apache.org wrote:
> 
>> proyal      2003/04/17 13:46:49
>>
>>   Modified:    datasource default.properties
>>                datasource/src/java/org/apache/avalon/excalibur/datasource
>>                         AbstractJdbcConnection.java
>>   Log:
>>   Throw the TargetException, so SQLException's get thrown correctly. DOH!
> 
> 
> We may want to do a 'brown-paper-bag' release on datasource...
> -pete


A 0.0.1 release?  Sure.


-- 
"You know the world is going crazy when the best
rapper is a white guy, the best golfer is a black guy,
The Swiss hold the America's Cup, France is
accusing the US of arrogance, and Germany doesn't want
to go to war. And the 3 most powerful men in America
are named 'Bush', 'Dick', and 'Colon' (sic)".

-----Chris Rock


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: cvs commit: avalon-excalibur/datasource/src/java/org/apache/avalon/excalibur/datasource AbstractJdbcConnection.java

Posted by Peter Royal <pr...@apache.org>.
On Thursday, April 17, 2003, at 04:46  PM, proyal@apache.org wrote:
> proyal      2003/04/17 13:46:49
>
>   Modified:    datasource default.properties
>                
> datasource/src/java/org/apache/avalon/excalibur/datasource
>                         AbstractJdbcConnection.java
>   Log:
>   Throw the TargetException, so SQLException's get thrown correctly. 
> DOH!

We may want to do a 'brown-paper-bag' release on datasource...
-pete


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org