[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2858: HDDS-5869. [Ozone-Streaming] Added support for stream on S3Gateway wr…

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2858:
URL: https://github.com/apache/ozone/pull/2858#discussion_r755417782



##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java
##########
@@ -157,8 +166,6 @@ public Response put(
       @QueryParam("uploadId") @DefaultValue("") String uploadID,

Review comment:
       @szetszwo and @guohao-rosicky I donot have much context on Streaming. But my comment is from the perspective of S3.
   
   >Similar to partNumber and uploadId, this parameter is Ozone specific. We may change the default to true later on >when the streaming feature is ready.
   
   This is also part of AWS S3 protocol for multipart upload.
   
   Adding a query param streaming from AWS S3 SDK will not be possible for passing this param. I think based on the config selecting streaming or non-streaming would be the way to go here.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org