You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by ng...@apache.org on 2008/08/26 08:46:56 UTC

svn commit: r688971 - /mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java

Author: ngn
Date: Mon Aug 25 23:46:55 2008
New Revision: 688971

URL: http://svn.apache.org/viewvc?rev=688971&view=rev
Log:
Try using getBoolean instead of trying to detect a boolean ourselves, need confirmation (FTPSERVER-168)

Modified:
    mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java

Modified: mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java
URL: http://svn.apache.org/viewvc/mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java?rev=688971&r1=688970&r2=688971&view=diff
==============================================================================
--- mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java (original)
+++ mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java Mon Aug 25 23:46:55 2008
@@ -495,12 +495,6 @@
             }
         }
     }
-
-    private boolean isTrue(String s) {
-        return "true".equalsIgnoreCase(s) ||
-                "1".equalsIgnoreCase(s) ||
-                "yes".equalsIgnoreCase(s);
-    }
     
     /**
      * Get the user object. Fetch the row from the table.
@@ -528,12 +522,11 @@
                 thisUser = new BaseUser();
                 thisUser.setName(rs.getString(ATTR_LOGIN));
                 thisUser.setHomeDirectory(rs.getString(ATTR_HOME));
-                thisUser.setEnabled(isTrue(rs
-                        .getString(ATTR_ENABLE)));
+                thisUser.setEnabled(rs.getBoolean(ATTR_ENABLE));
                 thisUser.setMaxIdleTime(rs.getInt(ATTR_MAX_IDLE_TIME));
 
                 List<Authority> authorities = new ArrayList<Authority>();
-                if (isTrue(rs.getString(ATTR_WRITE_PERM))) {
+                if (rs.getBoolean(ATTR_WRITE_PERM)) {
                     authorities.add(new WritePermission());
                 }