[GitHub] [guacamole-client] necouchman commented on a change in pull request #584: GUACAMOLE-1199: Only update unrestricted JDBC attributes if they have been provided.

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #584:
URL: https://github.com/apache/guacamole-client/pull/584#discussion_r693355845



##########
File path: extensions/guacamole-auth-totp/src/main/java/org/apache/guacamole/auth/totp/user/UserVerificationService.java
##########
@@ -166,7 +166,7 @@ private boolean setKey(UserContext context, UserTOTPKey key)
 
         // Get mutable set of attributes
         User self = context.self();
-        Map<String, String> attributes = new HashMap<String, String>();
+        Map<String, String> attributes = new HashMap<>(self.getAttributes());

Review comment:
       Okay, I _think_ I've finally managed to get it - pretty much as simple as you said :smile:. Testing looks good - the attributes appear to be maintained across TOTP enrollment, and the fields are present both when editing a user and when creating a new user.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org