You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by TILL TOENSHOFF <to...@me.com> on 2014/01/15 05:04:53 UTC
Review Request 16897: control may reach end of non-void function in
encoder.hpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16897/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Bugs: MESOS-908
https://issues.apache.org/jira/browse/MESOS-908
Repository: mesos-git
Description
-------
Fixes warning of "control may reach end of non-void function" in encoder.hpp that occurs when compiling using clang.
Diffs
-----
3rdparty/libprocess/src/encoder.hpp 55aba22
Diff: https://reviews.apache.org/r/16897/diff/
Testing
-------
make check
Thanks,
TILL TOENSHOFF
Re: Review Request 16897: control may reach end of non-void function in
encoder.hpp
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Jan. 14, 2014, 9:31 p.m., Niklas Nielsen wrote:
> > Ship It!
Thanks Till! Just committed this - can you mark the request as submitted?
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16897/#review31851
-----------------------------------------------------------
On Jan. 14, 2014, 8:04 p.m., TILL TOENSHOFF wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16897/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 8:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-908
> https://issues.apache.org/jira/browse/MESOS-908
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes warning of "control may reach end of non-void function" in encoder.hpp that occurs when compiling using clang.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/encoder.hpp 55aba22
>
> Diff: https://reviews.apache.org/r/16897/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> TILL TOENSHOFF
>
>
Re: Review Request 16897: control may reach end of non-void function in
encoder.hpp
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16897/#review31851
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 14, 2014, 8:04 p.m., TILL TOENSHOFF wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16897/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 8:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-908
> https://issues.apache.org/jira/browse/MESOS-908
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes warning of "control may reach end of non-void function" in encoder.hpp that occurs when compiling using clang.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/encoder.hpp 55aba22
>
> Diff: https://reviews.apache.org/r/16897/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> TILL TOENSHOFF
>
>
Re: Review Request 16897: control may reach end of non-void function in
encoder.hpp
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16897/#review31850
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 15, 2014, 4:04 a.m., TILL TOENSHOFF wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16897/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 4:04 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-908
> https://issues.apache.org/jira/browse/MESOS-908
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes warning of "control may reach end of non-void function" in encoder.hpp that occurs when compiling using clang.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/encoder.hpp 55aba22
>
> Diff: https://reviews.apache.org/r/16897/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> TILL TOENSHOFF
>
>