You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2022/08/05 22:59:44 UTC
[GitHub] [incubator-pagespeed-mod] oschaaf opened a new pull request, #2095: Update to Envoy 5261b42
oschaaf opened a new pull request, #2095:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2095
- Upgrade to the latest Envoy dependency
- Purge the re2 dependency we manage: we can now rely on Envoy for it
- Changes/cleanup around -std=c++17
- Unbreak SerfUrlAsyncFetcherTest.TestHttpsSucceedsForGoogleCom
- General code-level changes to accommodate the new Envoy version
- Disable the Envoy-native fetcher test: it broke, but it's not used
we may consider either stripping it or fixing it later.
- Leave a note about RunningOnValgrind needing cleanup and stub it.
Signed-off-by: Otto van der Schaaf <os...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf merged pull request #2095: Update to Envoy 5261b42
Posted by GitBox <gi...@apache.org>.
oschaaf merged PR #2095:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf commented on pull request #2095: Update to Envoy 5261b42
Posted by GitBox <gi...@apache.org>.
oschaaf commented on PR #2095:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2095#issuecomment-1207095773
Just found out that this will need a follow up: the benchmarks broke.
I forgot that we used to tweak the re2 dependency through a patch, in order for us to use its benchmarking features.
That was dropped as we can piggy back on the re2 dependency that Envoy brings in for all other use-cases, and I only tested the benchmarks just now.
The re2 `//:benchmark` target is invisible in the vanilla dependency, so we need to either wire in a way to keep on applying that patch so we can continue to rely on it, or rewrite our benchmarking tests to not rely on re2's features for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org