You are viewing a plain text version of this content. The canonical link for it is here.

Posted to fop-dev@xmlgraphics.apache.org by Alexios Giotis <al...@gmail.com> on 2012/03/02 15:22:45 UTC

Broken ExampleJava2D2PDF

Hi Glenn,

The complex scripts patch seems to have broken examples/embedding/java/embedding/ExampleJava2D2PDF.java

It would be good if by default the examples are compiled to avoid this in future. The fix is really easy:


@@ -66,7 +66,8 @@
                 throws ConfigurationException {
 
         PDFDocumentGraphics2DConfigurator configurator = new PDFDocumentGraphics2DConfigurator();
-        configurator.configure(g2d, cfg);
+        boolean useComplexScriptFeatures = false;
+        configurator.configure(g2d, cfg, useComplexScriptFeatures);
     }



Alex Giotis

Re: Broken ExampleJava2D2PDF

Posted by Glenn Adams <gl...@skynav.com>.

Fixed [1].

[1] http://svn.apache.org/viewvc?view=revision&revision=1296385

On Fri, Mar 2, 2012 at 7:22 AM, Alexios Giotis <al...@gmail.com>wrote:

> Hi Glenn,
>
> The complex scripts patch seems to have broken
> examples/embedding/java/embedding/ExampleJava2D2PDF.java
>
> It would be good if by default the examples are compiled to avoid this in
> future. The fix is really easy:
>
>
> @@ -66,7 +66,8 @@
>                 throws ConfigurationException {
>
>         PDFDocumentGraphics2DConfigurator configurator = new
> PDFDocumentGraphics2DConfigurator();
> -        configurator.configure(g2d, cfg);
> +        boolean useComplexScriptFeatures = false;
> +        configurator.configure(g2d, cfg, useComplexScriptFeatures);
>     }
>
>
>
> Alex Giotis
>
>
>

Re: Broken ExampleJava2D2PDF

Posted by Glenn Adams <gl...@skynav.com>.

Thanks Alex for pointing this out. I'll fix right away. I had not
previously compiled (or used) any of the examples, so did not notice this
breakage.

G.

On Fri, Mar 2, 2012 at 7:22 AM, Alexios Giotis <al...@gmail.com>wrote:

> Hi Glenn,
>
> The complex scripts patch seems to have broken
> examples/embedding/java/embedding/ExampleJava2D2PDF.java
>
> It would be good if by default the examples are compiled to avoid this in
> future. The fix is really easy:
>
>
> @@ -66,7 +66,8 @@
>                 throws ConfigurationException {
>
>         PDFDocumentGraphics2DConfigurator configurator = new
> PDFDocumentGraphics2DConfigurator();
> -        configurator.configure(g2d, cfg);
> +        boolean useComplexScriptFeatures = false;
> +        configurator.configure(g2d, cfg, useComplexScriptFeatures);
>     }
>
>
>
> Alex Giotis
>
>
>