You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "sunrioa (via GitHub)" <gi...@apache.org> on 2026/08/20 17:43:33 UTC
[PR] fix(desktop): use a supported macOS bundle icon size [maka]
sunrioa opened a new pull request, #3353:
URL: https://github.com/apache/maka/pull/3353
## Summary
Use Electron's macOS-supported `normal` file-icon size for the packaged permission overlay. Both native bundle-icon reads now share the same option, while unpackaged development continues to skip native icon loading.
Add a regression test covering the unpackaged bypass and the packaged `normal` option.
Fixes #3352
Refs #1919
Refs #1920
## Verification
Passed locally:
- `corepack npm --workspace @maka/desktop test` — 979 passed
- `corepack npm --workspace @maka/desktop run e2e` — 34 passed, 1 skipped
- `corepack npm run lint` — passed
- `corepack npm run format:check` — passed
- `corepack npm run build` — passed
- `corepack npm run typecheck` — passed
- `corepack npm exec -- knip --workspace apps/desktop` — passed
- `corepack npm exec -- knip --workspace packages/ui` — passed
- `corepack npm run astryx:theme -- --check` — passed
- `node scripts/audit-alignment.mjs` — passed
- `node --test --test-concurrency=1 scripts/ci-test-plan.test.mjs` — 21 passed
- `corepack npm run windows:inventory` — passed
- `git diff --check` — passed
`corepack npm test` was also attempted, but was not green on this machine for failures outside this Desktop change:
- Eval's Harbor Python test requires Python 3.10+; this host has Python 3.9.6.
- One Storage child-process test treats Node's SQLite experimental warning on stderr as a failure; that test file passes 5/5 with `NODE_NO_WARNINGS=1`.
- Runtime and MCP passed when rerun separately (Runtime: 2968 passed, 13 skipped; MCP: 115 passed).
Not run:
- Manual smoke test of the fix in a signed/notarized macOS package; release signing/notarization credentials are unavailable.
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope:
OpenAI Codex assisted with crash-log analysis, implementation, the regression test, local verification, and drafting this description. I reviewed the final diff and test results.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): use a supported macOS bundle icon size [maka]
Posted by "sunrioa (via GitHub)" <gi...@apache.org>.
sunrioa commented on PR #3353:
URL: https://github.com/apache/maka/pull/3353#issuecomment-5379231060
Closing as superseded by #3455, which independently fixed the same packaged macOS `large` icon crash and has now been merged. The canonical-icon follow-up is being tracked in #3464. Thanks to the maintainers and contributors for carrying this through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): use a supported macOS bundle icon size [maka]
Posted by "sunrioa (via GitHub)" <gi...@apache.org>.
sunrioa closed pull request #3353: fix(desktop): use a supported macOS bundle icon size
URL: https://github.com/apache/maka/pull/3353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org