You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/04 20:36:03 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #262: Implement select distinct

Dandandan commented on a change in pull request #262:
URL: https://github.com/apache/arrow-datafusion/pull/262#discussion_r626089767



##########
File path: datafusion/src/sql/planner.rs
##########
@@ -649,20 +657,15 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
     /// necessary, i.e., when the input fields are different than the
     /// projection. Note that if the input fields are the same, but out of
     /// order, the projection will be applied.
-    fn project(
-        &self,
-        input: &LogicalPlan,
-        expr: Vec<Expr>,
-        force: bool,

Review comment:
       small drive-by simplification, an unused option




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org