[GitHub] [spark] MaxGekk commented on a change in pull request #24339: [SPARK-27436][SQL] Add spark.sql.optimizer.nonExcludedRules

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #24339: [SPARK-27436][SQL] Add spark.sql.optimizer.nonExcludedRules
URL: https://github.com/apache/spark/pull/24339#discussion_r274264451
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ##########
 @@ -218,7 +219,8 @@ abstract class Optimizer(sessionCatalog: SessionCatalog)
       RewriteCorrelatedScalarSubquery.ruleName ::
       RewritePredicateSubquery.ruleName ::
       PullOutPythonUDFInJoinCondition.ruleName ::
-      NormalizeFloatingNumbers.ruleName :: Nil
+      NormalizeFloatingNumbers.ruleName :: Nil ++
+      SQLConf.get.getConf(OPTIMIZER_NON_EXCLUDABLE_RULES).toSeq.flatMap(Utils.stringToSeq)
 
 Review comment:
   Does it make sense to replace type of `nonExcludableRules` to `Set` since the main method applied to the data structure is `contains`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org