You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Sean Qiu (JIRA)" <ji...@apache.org> on 2007/08/07 07:33:59 UTC
[jira] Created: (HARMONY-4603) [classlib][util]
LinkedHashMap.clone() has problem when override the removeEldestEntry
method
[classlib][util] LinkedHashMap.clone() has problem when override the removeEldestEntry method
---------------------------------------------------------------------------------------------
Key: HARMONY-4603
URL: https://issues.apache.org/jira/browse/HARMONY-4603
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Sean Qiu
LinkedHashMap.clone() has problem when override the removeEldestEntry method
===== Test =====
public class LinkedHashMapTest extends TestCase {
public void test_clone() {
LinkedHashMap hashMap = new MockMap();
String value = "value a";
hashMap.put("key", value);
MockMap cloneMap = (MockMap) hashMap.clone();
assertEquals(value, cloneMap.get("key"));
assertEquals(hashMap, cloneMap);
assertEquals(1, cloneMap.num);
hashMap.put("key", "value b");
assertFalse(hashMap.equals(cloneMap));
}
class MockMap extends LinkedHashMap {
int num;
public Object put(Object k, Object v) {
num++;
return super.put(k, v);
}
protected boolean removeEldestEntry(Map.Entry e) {
return num > 1;
}
}
}
=== Result ===
RI: Pass
Harmy: Fail
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4603) [classlib][util]
LinkedHashMap.clone() has problem when override the removeEldestEntry
method
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy, Jing Lv updated HARMONY-4603:
------------------------------------
Attachment: Harmony4603.diff
> [classlib][util] LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ---------------------------------------------------------------------------------------------
>
> Key: HARMONY-4603
> URL: https://issues.apache.org/jira/browse/HARMONY-4603
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sean Qiu
> Assignee: Leo Li
> Attachments: Harmony4603.diff
>
>
> LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ===== Test =====
> public class LinkedHashMapTest extends TestCase {
> public void test_clone() {
> LinkedHashMap hashMap = new MockMap();
> String value = "value a";
> hashMap.put("key", value);
> MockMap cloneMap = (MockMap) hashMap.clone();
> assertEquals(value, cloneMap.get("key"));
> assertEquals(hashMap, cloneMap);
> assertEquals(1, cloneMap.num);
> hashMap.put("key", "value b");
> assertFalse(hashMap.equals(cloneMap));
> }
> class MockMap extends LinkedHashMap {
> int num;
> public Object put(Object k, Object v) {
> num++;
> return super.put(k, v);
> }
> protected boolean removeEldestEntry(Map.Entry e) {
> return num > 1;
> }
> }
> }
> === Result ===
> RI: Pass
> Harmy: Fail
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4603) [classlib][util]
LinkedHashMap.clone() has problem when override the removeEldestEntry
method
Posted by "Sean Qiu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Qiu closed HARMONY-4603.
-----------------------------
> [classlib][util] LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ---------------------------------------------------------------------------------------------
>
> Key: HARMONY-4603
> URL: https://issues.apache.org/jira/browse/HARMONY-4603
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sean Qiu
> Assignee: Leo Li
> Attachments: Harmony4603.diff, Harmony4603.diff
>
>
> LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ===== Test =====
> public class LinkedHashMapTest extends TestCase {
> public void test_clone() {
> LinkedHashMap hashMap = new MockMap();
> String value = "value a";
> hashMap.put("key", value);
> MockMap cloneMap = (MockMap) hashMap.clone();
> assertEquals(value, cloneMap.get("key"));
> assertEquals(hashMap, cloneMap);
> assertEquals(1, cloneMap.num);
> hashMap.put("key", "value b");
> assertFalse(hashMap.equals(cloneMap));
> }
> class MockMap extends LinkedHashMap {
> int num;
> public Object put(Object k, Object v) {
> num++;
> return super.put(k, v);
> }
> protected boolean removeEldestEntry(Map.Entry e) {
> return num > 1;
> }
> }
> }
> === Result ===
> RI: Pass
> Harmy: Fail
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4603) [classlib][util]
LinkedHashMap.clone() has problem when override the removeEldestEntry
method
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leo Li reassigned HARMONY-4603:
-------------------------------
Assignee: Leo Li
> [classlib][util] LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ---------------------------------------------------------------------------------------------
>
> Key: HARMONY-4603
> URL: https://issues.apache.org/jira/browse/HARMONY-4603
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sean Qiu
> Assignee: Leo Li
> Attachments: Harmony4603.diff
>
>
> LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ===== Test =====
> public class LinkedHashMapTest extends TestCase {
> public void test_clone() {
> LinkedHashMap hashMap = new MockMap();
> String value = "value a";
> hashMap.put("key", value);
> MockMap cloneMap = (MockMap) hashMap.clone();
> assertEquals(value, cloneMap.get("key"));
> assertEquals(hashMap, cloneMap);
> assertEquals(1, cloneMap.num);
> hashMap.put("key", "value b");
> assertFalse(hashMap.equals(cloneMap));
> }
> class MockMap extends LinkedHashMap {
> int num;
> public Object put(Object k, Object v) {
> num++;
> return super.put(k, v);
> }
> protected boolean removeEldestEntry(Map.Entry e) {
> return num > 1;
> }
> }
> }
> === Result ===
> RI: Pass
> Harmy: Fail
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4603) [classlib][util]
LinkedHashMap.clone() has problem when override the removeEldestEntry
method
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521665 ]
Jimmy, Jing Lv commented on HARMONY-4603:
-----------------------------------------
Hi,
The fix is fine, Thanks! :)
Best Regards,
Jimmy
> [classlib][util] LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ---------------------------------------------------------------------------------------------
>
> Key: HARMONY-4603
> URL: https://issues.apache.org/jira/browse/HARMONY-4603
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sean Qiu
> Assignee: Leo Li
> Attachments: Harmony4603.diff, Harmony4603.diff
>
>
> LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ===== Test =====
> public class LinkedHashMapTest extends TestCase {
> public void test_clone() {
> LinkedHashMap hashMap = new MockMap();
> String value = "value a";
> hashMap.put("key", value);
> MockMap cloneMap = (MockMap) hashMap.clone();
> assertEquals(value, cloneMap.get("key"));
> assertEquals(hashMap, cloneMap);
> assertEquals(1, cloneMap.num);
> hashMap.put("key", "value b");
> assertFalse(hashMap.equals(cloneMap));
> }
> class MockMap extends LinkedHashMap {
> int num;
> public Object put(Object k, Object v) {
> num++;
> return super.put(k, v);
> }
> protected boolean removeEldestEntry(Map.Entry e) {
> return num > 1;
> }
> }
> }
> === Result ===
> RI: Pass
> Harmy: Fail
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4603) [classlib][util]
LinkedHashMap.clone() has problem when override the removeEldestEntry
method
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy, Jing Lv updated HARMONY-4603:
------------------------------------
Attachment: Harmony4603.diff
Hi,
It seems the patch has a little improvement in performance, great!
Would you please try my patch, thanks!
Best Regards,
Jimmy
> [classlib][util] LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ---------------------------------------------------------------------------------------------
>
> Key: HARMONY-4603
> URL: https://issues.apache.org/jira/browse/HARMONY-4603
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sean Qiu
> Attachments: Harmony4603.diff
>
>
> LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ===== Test =====
> public class LinkedHashMapTest extends TestCase {
> public void test_clone() {
> LinkedHashMap hashMap = new MockMap();
> String value = "value a";
> hashMap.put("key", value);
> MockMap cloneMap = (MockMap) hashMap.clone();
> assertEquals(value, cloneMap.get("key"));
> assertEquals(hashMap, cloneMap);
> assertEquals(1, cloneMap.num);
> hashMap.put("key", "value b");
> assertFalse(hashMap.equals(cloneMap));
> }
> class MockMap extends LinkedHashMap {
> int num;
> public Object put(Object k, Object v) {
> num++;
> return super.put(k, v);
> }
> protected boolean removeEldestEntry(Map.Entry e) {
> return num > 1;
> }
> }
> }
> === Result ===
> RI: Pass
> Harmy: Fail
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4603) [classlib][util]
LinkedHashMap.clone() has problem when override the removeEldestEntry
method
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leo Li resolved HARMONY-4603.
-----------------------------
Resolution: Fixed
Hi, Sean & Jimmy:
Patch applied at r565261. Thank you for your improvement. Please verify whether the problem is resolved as you expected.
Good luck!
Leo.
> [classlib][util] LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ---------------------------------------------------------------------------------------------
>
> Key: HARMONY-4603
> URL: https://issues.apache.org/jira/browse/HARMONY-4603
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sean Qiu
> Assignee: Leo Li
> Attachments: Harmony4603.diff, Harmony4603.diff
>
>
> LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ===== Test =====
> public class LinkedHashMapTest extends TestCase {
> public void test_clone() {
> LinkedHashMap hashMap = new MockMap();
> String value = "value a";
> hashMap.put("key", value);
> MockMap cloneMap = (MockMap) hashMap.clone();
> assertEquals(value, cloneMap.get("key"));
> assertEquals(hashMap, cloneMap);
> assertEquals(1, cloneMap.num);
> hashMap.put("key", "value b");
> assertFalse(hashMap.equals(cloneMap));
> }
> class MockMap extends LinkedHashMap {
> int num;
> public Object put(Object k, Object v) {
> num++;
> return super.put(k, v);
> }
> protected boolean removeEldestEntry(Map.Entry e) {
> return num > 1;
> }
> }
> }
> === Result ===
> RI: Pass
> Harmy: Fail
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4603) [classlib][util]
LinkedHashMap.clone() has problem when override the removeEldestEntry
method
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leo Li updated HARMONY-4603:
----------------------------
Attachment: (was: Harmony4603.diff)
> [classlib][util] LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ---------------------------------------------------------------------------------------------
>
> Key: HARMONY-4603
> URL: https://issues.apache.org/jira/browse/HARMONY-4603
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sean Qiu
> Assignee: Leo Li
> Attachments: Harmony4603.diff
>
>
> LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ===== Test =====
> public class LinkedHashMapTest extends TestCase {
> public void test_clone() {
> LinkedHashMap hashMap = new MockMap();
> String value = "value a";
> hashMap.put("key", value);
> MockMap cloneMap = (MockMap) hashMap.clone();
> assertEquals(value, cloneMap.get("key"));
> assertEquals(hashMap, cloneMap);
> assertEquals(1, cloneMap.num);
> hashMap.put("key", "value b");
> assertFalse(hashMap.equals(cloneMap));
> }
> class MockMap extends LinkedHashMap {
> int num;
> public Object put(Object k, Object v) {
> num++;
> return super.put(k, v);
> }
> protected boolean removeEldestEntry(Map.Entry e) {
> return num > 1;
> }
> }
> }
> === Result ===
> RI: Pass
> Harmy: Fail
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4603) [classlib][util]
LinkedHashMap.clone() has problem when override the removeEldestEntry
method
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy, Jing Lv updated HARMONY-4603:
------------------------------------
Attachment: Harmony4603.diff
> [classlib][util] LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ---------------------------------------------------------------------------------------------
>
> Key: HARMONY-4603
> URL: https://issues.apache.org/jira/browse/HARMONY-4603
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sean Qiu
> Assignee: Leo Li
> Attachments: Harmony4603.diff, Harmony4603.diff
>
>
> LinkedHashMap.clone() has problem when override the removeEldestEntry method
> ===== Test =====
> public class LinkedHashMapTest extends TestCase {
> public void test_clone() {
> LinkedHashMap hashMap = new MockMap();
> String value = "value a";
> hashMap.put("key", value);
> MockMap cloneMap = (MockMap) hashMap.clone();
> assertEquals(value, cloneMap.get("key"));
> assertEquals(hashMap, cloneMap);
> assertEquals(1, cloneMap.num);
> hashMap.put("key", "value b");
> assertFalse(hashMap.equals(cloneMap));
> }
> class MockMap extends LinkedHashMap {
> int num;
> public Object put(Object k, Object v) {
> num++;
> return super.put(k, v);
> }
> protected boolean removeEldestEntry(Map.Entry e) {
> return num > 1;
> }
> }
> }
> === Result ===
> RI: Pass
> Harmy: Fail
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.