[jira] [Comment Edited] (RATIS-288) Pom cleanup/simplification

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572046#comment-16572046 ] 

Tsz Wo Nicholas Sze edited comment on RATIS-288 at 8/7/18 6:02 PM:
-------------------------------------------------------------------

Just have tried the 006 patch.

- rat seems too strict for the normal builds -- it does not allow any files (e.g. patch files) in ratis directory.  It also disallows ratis-proto-shaded.iml (IntelliJ IDEA file) when running {{mvn -DskipShade test}}.
-* I am fine if rat is very strict in generating releases.
- Some typos in BUILDING.md
-* should be "mvn test"
 {code}
-$ mvn -DskipShade test
+$ mvn package -DskipShade 
{code}
-* should be "in `ratis-proto-shaded`".
{code}
+The compiled protocol-buffer definitions in this `hadoop-proto-shaded` are stored in the
{code}
-* The {{-DskipCleanShade}} is removed.  Is it still a valid option?  We should tell how to clean only the non-shaded artifacts.

Thanks a lot!



was (Author: szetszwo):
Just have tried the 006 patch.

- rat seems too strict for the normal builds -- it does not allow any files (e.g. patch files) in ratis directory.  It also disallows ratis-proto-shaded.iml (IntelliJ IDEA file) when running {{mvn -DskipShade test}}.
-* I am fine if rat is very strict in generating releases.
- Some typos in BUILDING.md
-* should be "mvn test"
 {code}
-$ mvn -DskipShade test
+$ mvn package -DskipShade 
{code}
-* should be "in `ratis-proto-shaded`".
{code}
+The compiled protocol-buffer definitions in this `hadoop-proto-shaded` are stored in the
{code}


> Pom cleanup/simplification
> --------------------------
>
>                 Key: RATIS-288
>                 URL: https://issues.apache.org/jira/browse/RATIS-288
>             Project: Ratis
>          Issue Type: Improvement
>          Components: build
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Minor
>         Attachments: RATIS-288.005.patch, RATIS-288.006.patch
>
>
> I'm noticing quite a bit of over-complication in the build, mostly around ratis-proto-shaded. From what I can tell in the git history, this is holdover from quite some time ago (when the module itself was introduced).
> Some weird things I see:
>  * Everything being marked as optional
>  * Explicit scope=compile being listed (this is the default)
>  * Inheriting all configuration from the netty-all pom (not sure why we'd want this)
>  * Recompilation of source files included in ratis-proto-shaded (shade-plugin can do this already)
> My only guess is that some of this was to support the {{skipShade}} option. I think I can halve the amount of time for the ratis-proto-shaded model, and still support a workflow that will let folks skip re-compilation if they haven't changed the protobufs



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)