[GitHub] [superset] jfrag1 commented on a diff in pull request #25020: fix(embedded sdk): Remove trailing slash from passed superset domain if there is one

["jfrag1 (via GitHub)" <gi...@apache.org>]

jfrag1 commented on code in PR #25020:
URL: https://github.com/apache/superset/pull/25020#discussion_r1305839651


##########
superset-embedded-sdk/package.json:
##########
@@ -1,6 +1,6 @@
 {
   "name": "@superset-ui/embedded-sdk",
-  "version": "0.1.0-alpha.9",
+  "version": "0.1.0-alpha.10",

Review Comment:
   I don't really have a strong opinion on this, but maybe it makes sense to do soon simply due to it being released for over a year now with no major issues?  cc @lilykuang who may have more context



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org