You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2023/06/14 23:33:04 UTC
[GitHub] [arrow] assignUser opened a new pull request, #36077: GH-36076: [C++] Remove deprecated cli flag
assignUser opened a new pull request, #36077:
URL: https://github.com/apache/arrow/pull/36077
### Rationale for this change
The deprecated flag causes errors on benchmark >= 1.6.1.
### Are there any user-facing changes?
No, benchmark defaults to an auto option to determine if colors are supported or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36077: GH-36076: [C++] Remove deprecated cli flag
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36077:
URL: https://github.com/apache/arrow/pull/36077#issuecomment-1595939568
Conbench analyzed the 6 benchmark runs on commit `1fb415c1`.
There was 1 benchmark result indicating a performance regression:
- Commit Run on `ursa-thinkcentre-m75q` at [2023-06-17 08:17:15Z](http://conbench.ursa.dev/compare/runs/a86eed59cb7a41e09a442d1cf83d46ed...1ad1a6969b5145a687d024863cb9e5b8/)
- [source=cpp-micro, suite=arrow-dataset-file-benchmark](http://conbench.ursa.dev/compare/benchmarks/0648d4732e0b7aac80006e28ce6a7381...0648d6cee81a755b8000bad72931ee6c)
The [full Conbench report](https://github.com/apache/arrow/runs/14349318974) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #36077: GH-36076: [C++] Remove deprecated cli flag
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #36077:
URL: https://github.com/apache/arrow/pull/36077#issuecomment-1592141389
Benchmark runs are scheduled for baseline = b4ac585ecb4da610cc64e346e564ca86594aec53 and contender = 2572a935fc14b97f56850e6a94647d30be9d315e. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c2fc9d2bf0384c33b1a44635072abd9b...c5ea264242d446318916ca33eba92b53/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3ba67613353548eeb97f8547fa50d633...eafdfabf49004c80a56fccb42f3d5838/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/61bc471bd1ac4b6ab5fb9a8c8d4d85ee...be72da655bfa49c9819eb3b69fe3a3a9/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9786ece2d4bb418c9f5f90a6849d25c3...11e2c10cf04e476d84724c8dc9e460c0/)
Buildkite builds:
[Scheduled] [`2572a935` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3055)
[Scheduled] [`2572a935` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3082)
[Scheduled] [`2572a935` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3047)
[Scheduled] [`2572a935` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3072)
[Finished] [`b4ac585e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3053)
[Scheduled] [`b4ac585e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3080)
[Scheduled] [`b4ac585e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3045)
[Scheduled] [`b4ac585e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3070)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36077: GH-36076: [C++] Remove deprecated cli flag
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36077:
URL: https://github.com/apache/arrow/pull/36077#issuecomment-1592130214
Revision: 2572a935fc14b97f56850e6a94647d30be9d315e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1024f61b25](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1024f61b25)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273158931/jobs/9536246874)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/5273157840/jobs/9536244634)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273157965/jobs/9536244999)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/14273715350)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273157432/jobs/9536243594)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5273158636/jobs/9536246265)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/5273158095/jobs/9536245185)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273157675/jobs/9536244200)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273158273/jobs/9536245509)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/5273157587/jobs/9536244000)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/5273159030/jobs/9536247068)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/5273158385/jobs/9536245766)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/5273157248/jobs/9536243320)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273157791/jobs/9536244514)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36077: GH-36076: [C++] Remove deprecated cli flag
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36077:
URL: https://github.com/apache/arrow/pull/36077#issuecomment-1592124366
:warning: GitHub issue #36076 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36077: GH-36076: [C++] Remove deprecated cli flag
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36077:
URL: https://github.com/apache/arrow/pull/36077#issuecomment-1592126501
Revision: a531424ff5cd872a8b6e4f6a8c6a0f114cd44a9c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ee335d0a77](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ee335d0a77)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273128667/jobs/9536184562)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/5273127679/jobs/9536182931)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273128168/jobs/9536183853)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/14273635533)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273129004/jobs/9536185217)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5273129914/jobs/9536187118)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/5273129319/jobs/9536185842)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273127892/jobs/9536183354)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273128368/jobs/9536184153)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/5273129137/jobs/9536185532)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/5273130057/jobs/9536187444)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/5273128851/jobs/9536185036)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/5273129591/jobs/9536186482)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5273127431/jobs/9536182680)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #36077: GH-36076: [C++] Remove deprecated cli flag
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #36077:
URL: https://github.com/apache/arrow/pull/36077#issuecomment-1592125195
Benchmark runs are scheduled for baseline = b4ac585ecb4da610cc64e346e564ca86594aec53 and contender = a531424ff5cd872a8b6e4f6a8c6a0f114cd44a9c. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c2fc9d2bf0384c33b1a44635072abd9b...803b69a71de84ad6a48ccdf253937535/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3ba67613353548eeb97f8547fa50d633...3b62e457ed7e45c6900cf541d28d8a8e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/61bc471bd1ac4b6ab5fb9a8c8d4d85ee...674df180941d43f3acd87837088795d6/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9786ece2d4bb418c9f5f90a6849d25c3...a44f456f26af4b7b9a7d297f7c09cac3/)
Buildkite builds:
[Scheduled] [`a531424f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3054)
[Scheduled] [`a531424f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3081)
[Scheduled] [`a531424f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3046)
[Scheduled] [`a531424f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3071)
[Finished] [`b4ac585e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3053)
[Scheduled] [`b4ac585e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3080)
[Scheduled] [`b4ac585e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3045)
[Scheduled] [`b4ac585e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3070)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #36077: GH-36076: [C++] Remove deprecated cli flag
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #36077:
URL: https://github.com/apache/arrow/pull/36077#issuecomment-1592124808
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser merged pull request #36077: GH-36076: [C++] Remove deprecated cli flag
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #36077:
URL: https://github.com/apache/arrow/pull/36077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #36077: GH-36076: [C++] Remove deprecated cli flag
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #36077:
URL: https://github.com/apache/arrow/pull/36077#issuecomment-1592125102
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #36077: GH-36076: [C++] Remove deprecated cli flag
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #36077:
URL: https://github.com/apache/arrow/pull/36077#issuecomment-1592141279
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org