Re: Review Request 61663: WebUI query plan graphs

[Peter Vary <pv...@cloudera.com>]

> On Aug. 30, 2017, 4:47 a.m., Xuefu Zhang wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java
> > Lines 127 (patched)
> > <https://reviews.apache.org/r/61663/diff/3/?file=1798755#file1798755line127>
> >
> >     What happens if this is a map-only task?

In the next patch I split the if statement


> On Aug. 30, 2017, 4:47 a.m., Xuefu Zhang wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java
> > Lines 132 (patched)
> > <https://reviews.apache.org/r/61663/diff/3/?file=1798755#file1798755line132>
> >
> >     It might be better if the null check is put in getCountersJson() method.

I think we should keep this, as it is - it is better to omit the "counter" element, than adding an empty one? What do you think?


> On Aug. 30, 2017, 4:47 a.m., Xuefu Zhang wrote:
> > service/src/resources/hive-webapps/static/css/query-plan-graph.css
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/61663/diff/3/?file=1798759#file1798759line1>
> >
> >     Apache license header if possible.

Done


> On Aug. 30, 2017, 4:47 a.m., Xuefu Zhang wrote:
> > service/src/resources/hive-webapps/static/js/query-plan-graph.js
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/61663/diff/3/?file=1798760#file1798760line1>
> >
> >     I think we need apache license header.

Done


> On Aug. 30, 2017, 4:47 a.m., Xuefu Zhang wrote:
> > service/src/resources/hive-webapps/static/js/vis.min.js
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/61663/diff/3/?file=1798761#file1798761line1>
> >
> >     Apache license header.

Done


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61663/#review184121
-----------------------------------------------------------


On Aug. 16, 2017, 1:55 p.m., Karen Coppage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61663/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2017, 1:55 p.m.)
> 
> 
> Review request for hive, Peter Vary and Xuefu Zhang.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> I’m working on a feature of the Hive WebUI Query Plan tab that would provide the option to display the query plan as a nice graph (scroll down for screenshots). If you click on one of the graph’s stages, the plan for that stage appears as text below.
> Stages are color-coded if they have a status (Success, Error, Running), and the rest are grayed out. Coloring is based on status already available in the WebUI, under the Stages tab.
> There is an additional option to display stats for MapReduce tasks. This includes the job’s ID, tracking URL (where the logs are found), and mapper and reducer numbers/progress, among other info.
> The library I’m using for the graph is called vis.js (http://visjs.org/). It has an Apache license, and the only necessary file to be included from this library is about 700 KB.
> I tried to keep server-side changes minimal, and graph generation is taken care of by the client. Plans with more than a given number of stages (default: 25) won't be displayed in order to preserve resources.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/LogUtils.java 0a3e0c7201 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3c158a6692 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4e7c80f184 
>   ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 4b6051485e 
>   ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java bf6cb91745 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 3c0719717c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 1bd4db7805 
>   service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon ff7476ee02 
>   service/src/resources/hive-webapps/static/css/query-plan-graph.css PRE-CREATION 
>   service/src/resources/hive-webapps/static/js/query-plan-graph.js PRE-CREATION 
>   service/src/resources/hive-webapps/static/js/vis.min.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61663/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karen Coppage
> 
>