You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@empire-db.apache.org by do...@apache.org on 2012/03/07 23:10:53 UTC
svn commit: r1298157 - in
/empire-db/trunk/empire-db/src/main/java/org/apache/empire: commons/ db/
db/oracle/ exceptions/ xml/
Author: doebele
Date: Wed Mar 7 22:10:52 2012
New Revision: 1298157
URL: http://svn.apache.org/viewvc?rev=1298157&view=rev
Log:
EMPIREDB-123
even more corrections
Modified:
empire-db/trunk/empire-db/src/main/java/org/apache/empire/commons/Attributes.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDDLGenerator.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDatabase.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDatabaseDriver.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBQuery.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBReader.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRecord.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRecordData.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRowSet.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBSQLScript.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBTable.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/DBCommandOracle.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/DBDatabaseDriverOracle.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/OracleDDLGenerator.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/exceptions/EmpireException.java
empire-db/trunk/empire-db/src/main/java/org/apache/empire/xml/XMLConfiguration.java
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/commons/Attributes.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/commons/Attributes.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/commons/Attributes.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/commons/Attributes.java Wed Mar 7 22:10:52 2012
@@ -32,7 +32,7 @@ import org.w3c.dom.Element;
*/
public class Attributes extends AbstractSet<Attributes.Attribute> implements Serializable
{
- static final class Attribute implements Serializable
+ public static final class Attribute implements Serializable
{
private static final long serialVersionUID = 1L;
private String name;
@@ -81,7 +81,7 @@ public class Attributes extends Abstract
}
}
- static final class EmptyIterator implements Iterator<Attribute>
+ private static final class EmptyIterator implements Iterator<Attribute>
{
public boolean hasNext() {
return false;
@@ -168,7 +168,7 @@ public class Attributes extends Abstract
}
/**
- * @param key the attribute
+ * @param name the attribute name
* @return the attribute value
*/
public int indexOf(String name)
@@ -187,7 +187,7 @@ public class Attributes extends Abstract
}
/**
- * @param key the attribute
+ * @param name the attribute name
* @return the attribute value
*/
public Object get(String name)
@@ -204,7 +204,7 @@ public class Attributes extends Abstract
/**
* @param name the attribute
- * @param object the attribute value
+ * @param The attribute to set
*/
public Attribute set(String name, Object value)
{
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDDLGenerator.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDDLGenerator.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDDLGenerator.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDDLGenerator.java Wed Mar 7 22:10:52 2012
@@ -91,7 +91,7 @@ public abstract class DBDDLGenerator<T e
* @param type
* @param size
* @param sql
- * @returns true if further column attributes may be added or false otherwise
+ * @return true if further column attributes may be added or false otherwise
*/
protected boolean appendColumnDataType(DataType type, double size, DBTableColumn c, StringBuilder sql)
{
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDatabase.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDatabase.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDatabase.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDatabase.java Wed Mar 7 22:10:52 2012
@@ -173,8 +173,6 @@ public abstract class DBDatabase extends
*
* @param driver the database driver
* @param conn the connection
- *
- * @return true on success
*/
public void open(DBDatabaseDriver driver, Connection conn)
{
@@ -211,8 +209,6 @@ public abstract class DBDatabase extends
* <P>
* @param driver The driver for which to create a DDL Script
* @param script the script object that will be completed
- *
- * @return the DLL script for creating the entire database schema
*/
public synchronized void getCreateDDLScript(DBDatabaseDriver driver, DBSQLScript script)
{
@@ -257,8 +253,6 @@ public abstract class DBDatabase extends
* Sets the schema for SQL statements.
*
* @param schema the schema to set
- *
- * @return true on success
*/
public void setSchema(String schema)
{ // Database must not be open so far
@@ -297,8 +291,6 @@ public abstract class DBDatabase extends
* Sets the name of the database link used to identify objects.
*
* @param linkName the database link name
- *
- * @return true on success
*/
public void setLinkName(String linkName)
{ // Database must not be open so far
@@ -432,7 +424,6 @@ public abstract class DBDatabase extends
* since it is internally called from the DBTable's constructor.
* <P>
* @param table the DBTable object
- * @return true if successful
*/
public void addTable(DBTable table)
{ // find column by name
@@ -484,7 +475,6 @@ public abstract class DBDatabase extends
* Adds a foreign key relation to the database.
* <P>
* @param reference a reference for a source and target column pair
- * @return true if the relations were successfully created.
*/
public final void addRelation(DBRelation.DBReference reference)
{
@@ -501,7 +491,6 @@ public abstract class DBDatabase extends
*
* @param ref1 a reference for a source and target column pair
* @param ref2 a reference for a source and target column pair
- * @return true if the relations were successfully created.
*/
public final void addRelation(DBRelation.DBReference ref1, DBRelation.DBReference ref2)
{
@@ -520,8 +509,6 @@ public abstract class DBDatabase extends
*
* @param name the relation name
* @param references a list of source and target column pairs
- *
- * @return true if the relations were successfully created.
*/
public void addRelation(String name, DBRelation.DBReference[] references)
{
@@ -574,7 +561,6 @@ public abstract class DBDatabase extends
* since it is internally called from the DBView's constructor.
* <P>
* @param view the DBView object
- * @return true if successful
*/
public void addView(DBView view)
{ // find column by name
@@ -624,7 +610,7 @@ public abstract class DBDatabase extends
}
/**
- * @return true if the database has been opened or false otherwise
+ * checks if the database has been opened or false otherwise
*/
protected void checkOpen()
{
@@ -1151,8 +1137,6 @@ public abstract class DBDatabase extends
* Connection.
*
* @param conn a valid database connection
- *
- * @return true if successful
*/
public void commit(Connection conn)
{
@@ -1177,8 +1161,6 @@ public abstract class DBDatabase extends
* Connection.
* <P>
* @param conn a valid database connection
- *
- * @return true if successful
*/
public void rollback(Connection conn)
{
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDatabaseDriver.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDatabaseDriver.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDatabaseDriver.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBDatabaseDriver.java Wed Mar 7 22:10:52 2012
@@ -791,8 +791,6 @@ public abstract class DBDatabaseDriver i
* @param type the command type
* @param dbo the database object
* @param script the script to complete
- *
- * @return true on success
*/
public void getDDLScript(DBCmdType type, DBObject dbo, DBSQLScript script)
{
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBQuery.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBQuery.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBQuery.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBQuery.java Wed Mar 7 22:10:52 2012
@@ -310,7 +310,6 @@ public class DBQuery extends DBRowSet
*
* @param rec the Record object
* @param keyValues an array of the primary key columns
- * @return true if successful
*/
@Override
public void initRecord(DBRecord rec, Object[] keyValues)
@@ -352,7 +351,6 @@ public class DBQuery extends DBRowSet
* @param rec the DBRecord object, contains all fields and the field properties
* @param key an array of the primary key columns
* @param conn a valid connection to the database.
- * @return true if successful
*/
@Override
public void readRecord(DBRecord rec, Object[] key, Connection conn)
@@ -387,7 +385,6 @@ public class DBQuery extends DBRowSet
*
* @param rec the DBRecord object. contains all fields and the field properties
* @param conn a valid connection to the database.
- * @return true if successful
*/
@Override
public void updateRecord(DBRecord rec, Connection conn)
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBReader.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBReader.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBReader.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBReader.java Wed Mar 7 22:10:52 2012
@@ -401,7 +401,6 @@ public class DBReader extends DBRecordDa
* @param cmd the SQL-Command with cmd.getSelect()
* @param scrollable true if the reader should be scrollable or false if not
* @param conn a valid JDBC connection.
- * @return true if successful
*/
public void open(DBCommandExpr cmd, boolean scrollable, Connection conn)
{
@@ -426,7 +425,6 @@ public class DBReader extends DBRecordDa
* </P>
* @param cmd the SQL-Command with cmd.getSelect()
* @param conn a valid JDBC connection.
- * @return true if successful
*/
public final void open(DBCommandExpr cmd, Connection conn)
{
@@ -445,7 +443,6 @@ public class DBReader extends DBRecordDa
* <P>
* @param cmd the SQL-Command with cmd.getSelect()
* @param conn a valid JDBC connection.
- * @return true if successful
*/
public void getRecordData(DBCommandExpr cmd, Connection conn)
{ // Open the record
@@ -702,7 +699,7 @@ public class DBReader extends DBRecordDa
/**
* Moves the cursor down one row from its current position.
*
- * @return true if successful
+ * @return the number of column descriptions added to the Element
*/
@Override
public int addColumnDesc(Element parent)
@@ -720,7 +717,7 @@ public class DBReader extends DBRecordDa
* Adds all children to a parent.
*
* @param parent the parent element below which to search the child
- * @return true if successful
+ * @return the number of row values added to the element
*/
@Override
public int addRowValues(Element parent)
@@ -752,7 +749,7 @@ public class DBReader extends DBRecordDa
* Adds all children to a parent.
*
* @param parent the parent element below which to search the child
- * @return true if successful
+ * @return the number of rows added to the element
*/
public int addRows(Element parent)
{
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRecord.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRecord.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRecord.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRecord.java Wed Mar 7 22:10:52 2012
@@ -496,7 +496,6 @@ public class DBRecord extends DBRecordDa
*
* @param index the index of the column
* @param value the value
- * @return true if successful
*/
public void setValue(int index, Object value)
{
@@ -529,7 +528,6 @@ public class DBRecord extends DBRecordDa
*
* @param column a DBColumn object
* @param value the value
- * @return true if successful
*/
public final void setValue(Column column, Object value)
{
@@ -594,7 +592,6 @@ public class DBRecord extends DBRecordDa
* @param table the rowset
* @param keyValues a Object array, the primary key(s)
* @param insert if true change the state of this object to REC_NEW
- * @return true if successful or false otherwise
*/
public void init(DBRowSet table, Object[] keyValues, boolean insert)
{ // Init with keys
@@ -613,7 +610,6 @@ public class DBRecord extends DBRecordDa
* <P>
* @param table the table for which to create a record
* @param conn a valid JDBC connection
- * @return true if successful
*/
public void create(DBRowSet table, Connection conn)
{
@@ -626,7 +622,6 @@ public class DBRecord extends DBRecordDa
* The record's state is set to NEW
* <P>
* @param table the table for which to create a record
- * @return true if successful
*/
public void create(DBRowSet table)
{
@@ -673,7 +668,6 @@ public class DBRecord extends DBRecordDa
*
* @see org.apache.empire.db.DBTable#updateRecord(DBRecord, Connection)
* @param conn a valid connection to the database.
- * @return true if successful
*/
public void update(Connection conn)
{
@@ -692,7 +686,6 @@ public class DBRecord extends DBRecordDa
*
* @see org.apache.empire.db.DBTable#deleteRecord(Object[], Connection)
* @param conn a valid connection to the database.
- * @return true if successful
*/
public void delete(Connection conn)
{
@@ -710,7 +703,7 @@ public class DBRecord extends DBRecordDa
/**
* This function set the field descriptions to the the XML tag.
*
- * @return true if successful
+ * @return the number of column descriptions added to the element
*/
@Override
public int addColumnDesc(Element parent)
@@ -735,7 +728,7 @@ public class DBRecord extends DBRecordDa
* Add the values of this record to the specified XML Element object.
*
* @param parent the XML Element object
- * @return true if successful
+ * @return the number of row values added to the element
*/
@Override
public int addRowValues(Element parent)
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRecordData.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRecordData.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRecordData.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRecordData.java Wed Mar 7 22:10:52 2012
@@ -331,7 +331,7 @@ public abstract class DBRecordData exten
/**
* Injects the current field values into a java bean.
*
- * @return true if successful
+ * @return the number of bean properties set on the supplied bean
*/
public int getBeanProperties(Object bean, Collection<ColumnExpr> ignoreList)
{
@@ -353,7 +353,7 @@ public abstract class DBRecordData exten
/**
* Injects the current field values into a java bean.
*
- * @return true if successful
+ * @return the number of bean properties set on the supplied bean
*/
public final int getBeanProperties(Object bean)
{
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRowSet.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRowSet.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRowSet.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBRowSet.java Wed Mar 7 22:10:52 2012
@@ -362,7 +362,6 @@ public abstract class DBRowSet extends D
*
* @param rec the DBRecord object to initialize this DBRowSet object
* @param state the state of this DBRowSet object
- * @return true if successful
*/
protected void prepareInitRecord(DBRecord rec, int state, Object rowSetData)
{
@@ -380,7 +379,6 @@ public abstract class DBRowSet extends D
* <P>
* @param rec the Record object
* @param keyValues an array of the primary key columns
- * @return true if successful
*/
public void initRecord(DBRecord rec, Object[] keyValues)
{
@@ -414,7 +412,6 @@ public abstract class DBRowSet extends D
* <P>
* @param rec the record object
* @param recData the record data from which to initialized the record
- * @return true if successful
*/
public void initRecord(DBRecord rec, DBRecordData recData)
{
@@ -455,7 +452,6 @@ public abstract class DBRowSet extends D
* Override this function to do post initialization processing.
* <P>
* @param rec the DBRecord object to initialize
- * @return true if successful
*/
protected void completeInitRecord(DBRecord rec)
{
@@ -495,7 +491,6 @@ public abstract class DBRowSet extends D
* @param rec the DBRecord object which holds the record data
* @param cmd the SQL-Command used to query the record
* @param conn a valid JDBC connection.
- * @return true if successful
*/
protected void readRecord(DBRecord rec, DBCommand cmd, Connection conn)
{
@@ -518,7 +513,6 @@ public abstract class DBRowSet extends D
* @param rec the DBRecord object which will hold the record data
* @param key the primary key values
* @param conn a valid JDBC connection.
- * @return true if successful
*/
public void readRecord(DBRecord rec, Object[] key, Connection conn)
{
@@ -544,7 +538,7 @@ public abstract class DBRowSet extends D
* <P>
* @param key an array of the primary key columns
* @param conn a valid JDBC connection.
- * @return true if successful or false otherwise
+ * @return true if the record exists or false otherwise
*/
public boolean recordExists(Object[] key, Connection conn)
{
@@ -565,7 +559,7 @@ public abstract class DBRowSet extends D
* <P>
* @param id id of the record
* @param conn a valid JDBC connection.
- * @return true if successful or false otherwise
+ * @return true if the record exists or false otherwise
*/
public final boolean recordExists(Object id, Connection conn)
{
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBSQLScript.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBSQLScript.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBSQLScript.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBSQLScript.java Wed Mar 7 22:10:52 2012
@@ -58,7 +58,6 @@ public class DBSQLScript implements Iter
/**
* Adds a statement to the script.
* @param sql the statement
- * @return true if successful
*/
public void addStmt(String sql)
{
@@ -69,7 +68,6 @@ public class DBSQLScript implements Iter
* Adds a statement to the script.<br>
* The supplied StringBuilder will be reset to a length of 0
* @param sql the statement
- * @return true if successful
*/
public final void addStmt(StringBuilder sql)
{
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBTable.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBTable.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBTable.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/DBTable.java Wed Mar 7 22:10:52 2012
@@ -275,8 +275,6 @@ public class DBTable extends DBRowSet im
* Sets the primary keys.
*
* @param columns a array with one or more DBColumn objects
- *
- * @return true on success
*/
public void setPrimaryKey(DBColumn[] columns)
{
@@ -326,11 +324,7 @@ public class DBTable extends DBRowSet im
/**
* Adds an index.
*
- * @param name the index name
- * @param unique is this a unique index
- * @param columns the columns indexed by this index
- *
- * @return true on success
+ * @param index the index to add
*/
public void addIndex(DBIndex index)
{
@@ -357,7 +351,7 @@ public class DBTable extends DBRowSet im
* @param unique is this a unique index
* @param columns the columns indexed by this index
*
- * @return true on success
+ * @return the Index object
*/
public DBIndex addIndex(String name, boolean unique, DBColumn[] columns)
{
@@ -415,8 +409,6 @@ public class DBTable extends DBRowSet im
*
* @param rec the DBRecord object. contains all fields and the field properties
* @param conn a valid connection to the database.
- *
- * @return true if successful
*/
@Override
public void createRecord(DBRecord rec, Connection conn)
@@ -463,7 +455,6 @@ public class DBTable extends DBRowSet im
*
* @param key an array of the primary key columns
* @param conn a valid connection to the database.
- * @return true if successful
*/
@Override
public void deleteRecord(Object[] key, Connection conn)
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/DBCommandOracle.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/DBCommandOracle.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/DBCommandOracle.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/DBCommandOracle.java Wed Mar 7 22:10:52 2012
@@ -128,7 +128,6 @@ public class DBCommandOracle extends DBC
* the Oracle database are supported.
*
* @param buf the SQL statement
- * @return true if the creation was successful
*/
@Override
public synchronized void getSelect(StringBuilder buf)
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/DBDatabaseDriverOracle.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/DBDatabaseDriverOracle.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/DBDatabaseDriverOracle.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/DBDatabaseDriverOracle.java Wed Mar 7 22:10:52 2012
@@ -358,8 +358,6 @@ public class DBDatabaseDriverOracle exte
/**
* Checks whether the database definition matches the real database structure.
- *
- * @return true if the database definition matches the real database structure.
*/
@Override
public void checkDatabase(DBDatabase db, String owner, Connection conn)
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/OracleDDLGenerator.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/OracleDDLGenerator.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/OracleDDLGenerator.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/db/oracle/OracleDDLGenerator.java Wed Mar 7 22:10:52 2012
@@ -118,8 +118,6 @@ public class OracleDDLGenerator extends
/**
* Returns true if the sequence has been created successfully.
- *
- * @return true if the sequence has been created successfully
*/
protected void createSequence(DBDatabase db, DBTableColumn c, DBSQLScript script)
{
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/exceptions/EmpireException.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/exceptions/EmpireException.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/exceptions/EmpireException.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/exceptions/EmpireException.java Wed Mar 7 22:10:52 2012
@@ -73,7 +73,6 @@ public class EmpireException extends Run
* Constructor for derived classes
* @param errType
* @param params
- * @param cause
*/
protected EmpireException(final ErrorType errType, final String[] params)
{
Modified: empire-db/trunk/empire-db/src/main/java/org/apache/empire/xml/XMLConfiguration.java
URL: http://svn.apache.org/viewvc/empire-db/trunk/empire-db/src/main/java/org/apache/empire/xml/XMLConfiguration.java?rev=1298157&r1=1298156&r2=1298157&view=diff
==============================================================================
--- empire-db/trunk/empire-db/src/main/java/org/apache/empire/xml/XMLConfiguration.java (original)
+++ empire-db/trunk/empire-db/src/main/java/org/apache/empire/xml/XMLConfiguration.java Wed Mar 7 22:10:52 2012
@@ -66,8 +66,6 @@ public class XMLConfiguration
*
* @param filename the file
* @param fromResource will read from the classpath if true
- *
- * @return true on success
*/
public void init(String filename, boolean fromResource)
{
@@ -137,8 +135,7 @@ public class XMLConfiguration
/**
* reads all properties from a given properties node and applies them to the given bean
* @param bean the bean to which to apply the configuration
- * @param propertiesNodeName the name of the properties node below the root element
- * @return true of successful or false otherwise
+ * @param propertiesNodeNames the name of the properties node below the root element
*/
public void readProperties(Object bean, String... propertiesNodeNames)
{
@@ -170,7 +167,6 @@ public class XMLConfiguration
* reads all properties from a given properties node and applies them to the given bean
* @param bean the bean to which to apply the configuration
* @param propertiesNode the properties node
- * @return true of successful or false otherwise
*/
public void readProperties(Object bean, Element propertiesNode)
{