[GitHub] [pulsar] eolivelli commented on a change in pull request #14508: [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #14508:
URL: https://github.com/apache/pulsar/pull/14508#discussion_r816948939



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/schema/SchemaTest.java
##########
@@ -708,7 +709,7 @@ public void testNullKeyValueProperty() throws PulsarAdminException, PulsarClient
         map.put(null, "value"); // null key is not allowed for JSON, it's only for test here
 
         // leave INT32 instance unchanged
-        final Schema<Integer> integerSchema = Schema.INT32.clone();
+        final Schema<Integer> integerSchema = DefaultImplementation.getDefaultImplementation().newIntSchema();

Review comment:
       This is not good.
   it means that users that use the public API Schema.INT32 and use clone() see surprises.
   
   I believe that the problem is that clone() is not working properly 
   
   Schema are stateful objects in Pulsar and clone() is very important
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org