You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2023/06/23 19:59:43 UTC
[pinot] branch master updated: Remove handle out-of-order from updateRecord method (#10968)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f8e783899f Remove handle out-of-order from updateRecord method (#10968)
f8e783899f is described below
commit f8e783899f9a327b162c8cd62ca75cfaf410cba6
Author: Pratik Tibrewal <ti...@uber.com>
AuthorDate: Sat Jun 24 01:29:38 2023 +0530
Remove handle out-of-order from updateRecord method (#10968)
---
.../pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java | 3 ++-
.../local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
index 92c1a18749..89ae1ba534 100644
--- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
+++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
@@ -423,7 +423,8 @@ public abstract class BasePartitionUpsertMetadataManager implements PartitionUps
if (currentTimeNs - _lastOutOfOrderEventReportTimeNs > OUT_OF_ORDER_EVENT_MIN_REPORT_INTERVAL_NS) {
_logger.warn("Skipped {} out-of-order events for {} upsert table {} (the last event has current comparison "
+ "value: {}, record comparison value: {})", _numOutOfOrderEvents,
- (isPartialUpsertTable ? "partial" : ""), _tableNameWithType, currentComparisonValue, recordComparisonValue);
+ (isPartialUpsertTable ? "partial" : "full"), _tableNameWithType, currentComparisonValue,
+ recordComparisonValue);
_lastOutOfOrderEventReportTimeNs = currentTimeNs;
_numOutOfOrderEvents = 0;
}
diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java
index 6e8b195bbc..e7ad9c5919 100644
--- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java
+++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java
@@ -284,7 +284,6 @@ public class ConcurrentMapPartitionUpsertMetadataManager extends BasePartitionUp
}
return _partialUpsertHandler.merge(previousRecord, record);
} else {
- handleOutOfOrderEvent(currentRecordLocation.getComparisonValue(), recordInfo.getComparisonValue());
return record;
}
} else {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org