You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mv...@apache.org on 2012/03/23 13:50:14 UTC
svn commit: r1304320 -
/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Author: mvg
Date: Fri Mar 23 12:50:14 2012
New Revision: 1304320
URL: http://svn.apache.org/viewvc?rev=1304320&view=rev
Log:
fixed small typo
Modified:
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java?rev=1304320&r1=1304319&r2=1304320&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java Fri Mar 23 12:50:14 2012
@@ -3699,7 +3699,7 @@ public class IndexWriter implements Clos
}
/**
- * Returns <code>true</code> iff the index in the named directory is
+ * Returns <code>true</code> if the index in the named directory is
* currently locked.
* @param directory the directory to check for a lock
* @throws IOException if there is a low-level IO error
Re: svn commit: r1304320 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Martijn v Groningen <ma...@gmail.com>.
I don't know. I wasn't aware that "iff" has a meaning. I'll change it back
if it is: "if and only if".
Martijn
On 23 March 2012 13:57, Robert Muir <rc...@gmail.com> wrote:
> Is this a typo or intended to be iff (if and only if)?
>
> On Fri, Mar 23, 2012 at 8:50 AM, <mv...@apache.org> wrote:
> > Author: mvg
> > Date: Fri Mar 23 12:50:14 2012
> > New Revision: 1304320
> >
> > URL: http://svn.apache.org/viewvc?rev=1304320&view=rev
> > Log:
> > fixed small typo
> >
> > Modified:
> >
> lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
> >
> > Modified:
> lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
> > URL:
> http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java?rev=1304320&r1=1304319&r2=1304320&view=diff
> >
> ==============================================================================
> > ---
> lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
> (original)
> > +++
> lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
> Fri Mar 23 12:50:14 2012
> > @@ -3699,7 +3699,7 @@ public class IndexWriter implements Clos
> > }
> >
> > /**
> > - * Returns <code>true</code> iff the index in the named directory is
> > + * Returns <code>true</code> if the index in the named directory is
> > * currently locked.
> > * @param directory the directory to check for a lock
> > * @throws IOException if there is a low-level IO error
> >
> >
>
>
>
> --
> lucidimagination.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
Met vriendelijke groet,
Martijn van Groningen
Re: svn commit: r1304320 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
iff is academic jargon. Let's be explicit.
Dawid
On Fri, Mar 23, 2012 at 2:46 PM, Erick Erickson <er...@gmail.com> wrote:
> Early days of electronic text and a math professor I had had a colleague
> who submitted a math textbook. Someone decided that "iff" was a typo
> and did a mass substitution of "if". As my prof said
>
> "Going through a math text and putting back all the iff's that were
> supposed to be in the proofs was non-trivial"
>
> On Fri, Mar 23, 2012 at 9:23 AM, Martijn v Groningen
> <ma...@gmail.com> wrote:
>> I found 103 occurrences of "iff" in the codebase... most in lucene-core
>> For each case we need then to find out if this is or isn't typo, so an issue
>> for this would a good idea.
>>
>> On 23 March 2012 14:09, Robert Muir <rc...@gmail.com> wrote:
>>>
>>> this is all over the codebase too by the way. Maybe we should open an
>>> issue to fix this confusion?
>>>
>>> On Fri, Mar 23, 2012 at 9:08 AM, Martijn v Groningen
>>> <ma...@gmail.com> wrote:
>>> > On 23 March 2012 14:06, Robert Muir <rc...@gmail.com> wrote:
>>> >>
>>> >> I agree, and if its really important for some reason to document
>>> >> something as "if and only if", I think we should write it out
>>> >> completely and avoid specialized abbreviations.
>>> >
>>> > +1 I Completely agree.
>>> >
>>> > Martijn
>>>
>>>
>>>
>>> --
>>> lucidimagination.com
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>>
>>
>> --
>> Met vriendelijke groet,
>>
>> Martijn van Groningen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1304320 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Martijn v Groningen <ma...@gmail.com>.
>
> Early days of electronic text and a math professor I had had a colleague
> who submitted a math textbook. Someone decided that "iff" was a typo
> and did a mass substitution of "if". As my prof said
>
> "Going through a math text and putting back all the iff's that were
> supposed to be in the proofs was non-trivial"
>
I can image... I could have be that someone! Luckily we have version
control :-)
Re: svn commit: r1304320 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Erick Erickson <er...@gmail.com>.
Early days of electronic text and a math professor I had had a colleague
who submitted a math textbook. Someone decided that "iff" was a typo
and did a mass substitution of "if". As my prof said
"Going through a math text and putting back all the iff's that were
supposed to be in the proofs was non-trivial"
On Fri, Mar 23, 2012 at 9:23 AM, Martijn v Groningen
<ma...@gmail.com> wrote:
> I found 103 occurrences of "iff" in the codebase... most in lucene-core
> For each case we need then to find out if this is or isn't typo, so an issue
> for this would a good idea.
>
> On 23 March 2012 14:09, Robert Muir <rc...@gmail.com> wrote:
>>
>> this is all over the codebase too by the way. Maybe we should open an
>> issue to fix this confusion?
>>
>> On Fri, Mar 23, 2012 at 9:08 AM, Martijn v Groningen
>> <ma...@gmail.com> wrote:
>> > On 23 March 2012 14:06, Robert Muir <rc...@gmail.com> wrote:
>> >>
>> >> I agree, and if its really important for some reason to document
>> >> something as "if and only if", I think we should write it out
>> >> completely and avoid specialized abbreviations.
>> >
>> > +1 I Completely agree.
>> >
>> > Martijn
>>
>>
>>
>> --
>> lucidimagination.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
>
>
> --
> Met vriendelijke groet,
>
> Martijn van Groningen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1304320 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Martijn v Groningen <ma...@gmail.com>.
I found 103 occurrences of "iff" in the codebase... most in lucene-core
For each case we need then to find out if this is or isn't typo, so an
issue for this would a good idea.
On 23 March 2012 14:09, Robert Muir <rc...@gmail.com> wrote:
> this is all over the codebase too by the way. Maybe we should open an
> issue to fix this confusion?
>
> On Fri, Mar 23, 2012 at 9:08 AM, Martijn v Groningen
> <ma...@gmail.com> wrote:
> > On 23 March 2012 14:06, Robert Muir <rc...@gmail.com> wrote:
> >>
> >> I agree, and if its really important for some reason to document
> >> something as "if and only if", I think we should write it out
> >> completely and avoid specialized abbreviations.
> >
> > +1 I Completely agree.
> >
> > Martijn
>
>
>
> --
> lucidimagination.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
Met vriendelijke groet,
Martijn van Groningen
Re: svn commit: r1304320 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Robert Muir <rc...@gmail.com>.
this is all over the codebase too by the way. Maybe we should open an
issue to fix this confusion?
On Fri, Mar 23, 2012 at 9:08 AM, Martijn v Groningen
<ma...@gmail.com> wrote:
> On 23 March 2012 14:06, Robert Muir <rc...@gmail.com> wrote:
>>
>> I agree, and if its really important for some reason to document
>> something as "if and only if", I think we should write it out
>> completely and avoid specialized abbreviations.
>
> +1 I Completely agree.
>
> Martijn
--
lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1304320 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Martijn v Groningen <ma...@gmail.com>.
On 23 March 2012 14:06, Robert Muir <rc...@gmail.com> wrote:
> I agree, and if its really important for some reason to document
> something as "if and only if", I think we should write it out
> completely and avoid specialized abbreviations.
>
+1 I Completely agree.
Martijn
Re: svn commit: r1304320 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Robert Muir <rc...@gmail.com>.
I agree, and if its really important for some reason to document
something as "if and only if", I think we should write it out
completely and avoid specialized abbreviations.
On Fri, Mar 23, 2012 at 9:04 AM, Yonik Seeley
<yo...@lucidimagination.com> wrote:
> On Fri, Mar 23, 2012 at 8:57 AM, Robert Muir <rc...@gmail.com> wrote:
>> Is this a typo or intended to be iff (if and only if)?
>
> While it may not have been a typo, it was redundant/overkill (as it is
> for most uses in Lucene).
>
> -Yonik
> lucenerevolution.com - Lucene/Solr Open Source Search Conference.
> Boston May 7-10
>
>
>> On Fri, Mar 23, 2012 at 8:50 AM, <mv...@apache.org> wrote:
>>> Author: mvg
>>> Date: Fri Mar 23 12:50:14 2012
>>> New Revision: 1304320
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1304320&view=rev
>>> Log:
>>> fixed small typo
>>>
>>> Modified:
>>> lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
>>>
>>> Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
>>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java?rev=1304320&r1=1304319&r2=1304320&view=diff
>>> ==============================================================================
>>> --- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java (original)
>>> +++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java Fri Mar 23 12:50:14 2012
>>> @@ -3699,7 +3699,7 @@ public class IndexWriter implements Clos
>>> }
>>>
>>> /**
>>> - * Returns <code>true</code> iff the index in the named directory is
>>> + * Returns <code>true</code> if the index in the named directory is
>>> * currently locked.
>>> * @param directory the directory to check for a lock
>>> * @throws IOException if there is a low-level IO error
>>>
>>>
>>
>>
>>
>> --
>> lucidimagination.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--
lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1304320 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Yonik Seeley <yo...@lucidimagination.com>.
On Fri, Mar 23, 2012 at 8:57 AM, Robert Muir <rc...@gmail.com> wrote:
> Is this a typo or intended to be iff (if and only if)?
While it may not have been a typo, it was redundant/overkill (as it is
for most uses in Lucene).
-Yonik
lucenerevolution.com - Lucene/Solr Open Source Search Conference.
Boston May 7-10
> On Fri, Mar 23, 2012 at 8:50 AM, <mv...@apache.org> wrote:
>> Author: mvg
>> Date: Fri Mar 23 12:50:14 2012
>> New Revision: 1304320
>>
>> URL: http://svn.apache.org/viewvc?rev=1304320&view=rev
>> Log:
>> fixed small typo
>>
>> Modified:
>> lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
>>
>> Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java?rev=1304320&r1=1304319&r2=1304320&view=diff
>> ==============================================================================
>> --- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java (original)
>> +++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java Fri Mar 23 12:50:14 2012
>> @@ -3699,7 +3699,7 @@ public class IndexWriter implements Clos
>> }
>>
>> /**
>> - * Returns <code>true</code> iff the index in the named directory is
>> + * Returns <code>true</code> if the index in the named directory is
>> * currently locked.
>> * @param directory the directory to check for a lock
>> * @throws IOException if there is a low-level IO error
>>
>>
>
>
>
> --
> lucidimagination.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1304320 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Robert Muir <rc...@gmail.com>.
Is this a typo or intended to be iff (if and only if)?
On Fri, Mar 23, 2012 at 8:50 AM, <mv...@apache.org> wrote:
> Author: mvg
> Date: Fri Mar 23 12:50:14 2012
> New Revision: 1304320
>
> URL: http://svn.apache.org/viewvc?rev=1304320&view=rev
> Log:
> fixed small typo
>
> Modified:
> lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
>
> Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java?rev=1304320&r1=1304319&r2=1304320&view=diff
> ==============================================================================
> --- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java (original)
> +++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java Fri Mar 23 12:50:14 2012
> @@ -3699,7 +3699,7 @@ public class IndexWriter implements Clos
> }
>
> /**
> - * Returns <code>true</code> iff the index in the named directory is
> + * Returns <code>true</code> if the index in the named directory is
> * currently locked.
> * @param directory the directory to check for a lock
> * @throws IOException if there is a low-level IO error
>
>
--
lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org