You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2009/11/23 16:52:21 UTC
svn commit: r883383 - in /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp: TestAbandonedBasicDataSource.java TestManual.java TestPStmtPoolingBasicDataSource.java

Author: markt
Date: Mon Nov 23 15:52:21 2009
New Revision: 883383

URL: http://svn.apache.org/viewvc?rev=883383&view=rev
Log:
Fix FindBugs warnings
Dead store

Modified:
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAbandonedBasicDataSource.java
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPStmtPoolingBasicDataSource.java

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAbandonedBasicDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAbandonedBasicDataSource.java?rev=883383&r1=883382&r2=883383&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAbandonedBasicDataSource.java (original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestAbandonedBasicDataSource.java Mon Nov 23 15:52:21 2009
@@ -153,7 +153,7 @@
         Thread.sleep(500);
         conn1.prepareStatement("SELECT 1 FROM DUAL"); // reset
         Thread.sleep(800);
-        conn2 = ds.getConnection(); // trigger abandoned cleanup again
+        ds.getConnection(); // trigger abandoned cleanup again
         conn1.createStatement();         
     }
 }

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java?rev=883383&r1=883382&r2=883383&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java (original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java Mon Nov 23 15:52:21 2009
@@ -153,7 +153,7 @@
         driver.closePool("test");
 
         try {
-            conn = DriverManager.getConnection("jdbc:apache:commons:dbcp:test");
+            DriverManager.getConnection("jdbc:apache:commons:dbcp:test");
             fail("expected SQLException");
         }
         catch (SQLException e) {

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPStmtPoolingBasicDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPStmtPoolingBasicDataSource.java?rev=883383&r1=883382&r2=883383&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPStmtPoolingBasicDataSource.java (original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPStmtPoolingBasicDataSource.java Mon Nov 23 15:52:21 2009
@@ -68,7 +68,7 @@
         // go over the maxOpen limit
         PreparedStatement stmt3 = null;
         try {
-            stmt3 = conn.prepareStatement("select 'c' from dual");
+            conn.prepareStatement("select 'c' from dual");
             fail("expected SQLException");
         } 
         catch (SQLException e) {}