You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/02/09 07:29:13 UTC

[GitHub] marcoabreu commented on a change in pull request #9738: Add Support for int64

marcoabreu commented on a change in pull request #9738: Add Support for int64
URL: https://github.com/apache/incubator-mxnet/pull/9738#discussion_r167155802
 
 

 ##########
 File path: src/operator/tensor/indexing_op.h
 ##########
 @@ -836,12 +832,7 @@ struct OneHotParam : public dmlc::Parameter<OneHotParam> {
       .set_default(0.0f)
       .describe("The value assigned to the locations not represented by indices.");
     DMLC_DECLARE_FIELD(dtype)
-      .set_default(mshadow::kFloat32)
 
 Review comment:
   Was this removal intentional?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services