You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by liu-zhaokun <gi...@git.apache.org> on 2017/07/13 07:33:10 UTC
[GitHub] storm pull request #2207: [STORM-2626] Provided a template for drpc-auth-acl...
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2207
[STORM-2626] Provided a template for drpc-auth-acl.yaml
[https://issues.apache.org/jira/browse/STORM-2626](https://issues.apache.org/jira/browse/STORM-2626)
The default value of drpc.authorizer.acl.filename in defaults.yaml is "drpc-auth-acl.yaml",so I think we should provided a template for drpc-auth-acl.yaml.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liu-zhaokun/storm master07131509
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2207
----
commit 2dde576804477fdbc16a3de791245d047b32643d
Author: liuzhaokun <li...@zte.com.cn>
Date: 2017-07-13T07:31:50Z
[STORM-2626] Provided a template for drpc-auth-acl.yaml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@Ethanlm
Thanks for your reply.I will modify it follow your suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@revans2
Could you help me review this PR，there are no committer to review it all the time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@revans2
You are right.I created several PRs which has been mergerd that is related to ACL. I will update SECURITY.md in a new PR with these changes later.Could you help me merge this PR firstly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@vesense
I am so sorry to bother you.Do you have time to help me review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@harshach
I am so sorry to bother you.Do you have time to help me review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2207
Thanks. @liu-zhaokun . I was just thinking that adding some instructions on [SECURITY.md](https://github.com/apache/storm/blob/master/SECURITY.md#drpc-1) about DRPC is better than adding one more file in the _conf_ directory. It would make me nervous to see some many configuration files if I'm just a user. People don't even need to care about DRPC configuration if they are not using it. I would like to hear other people's opinions about this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@Ethanlm
Hi,could you help me review the new change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@HeartSaVioR
I am so sorry to bother you.Do you have time to help me review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@HeartSaVioR
Do you have time to help me review this PR,it's about drpc acl?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2207: [STORM-2626] Provided a template for drpc-auth-acl...
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2207#discussion_r128676343
--- Diff: conf/drpc-auth-acl.yaml.example ---
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+# For the function "jump", alice can perform client operations, and bob can
+# perform invocation operations.User should replace "jump","alice","bob","charlie" with their own value
--- End diff --
Sorry I should have stated it here. "bob" is not a invocation user in your example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2207
@Ethanlm
Ok,thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2207: [STORM-2626] Provided a template for drpc-auth-acl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2207
I do agree with @Ethanlm that updating SECURITY.md would probably be more helpful, but if you want this to be a first step then I am happy to merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---