You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "veghlaci05 (via GitHub)" <gi...@apache.org> on 2023/05/03 13:49:47 UTC
[GitHub] [hive] veghlaci05 commented on a diff in pull request #4279: HIVE-27307: NPE when generating incremental rebuild plan of materialized view with empty Iceberg source table
veghlaci05 commented on code in PR #4279:
URL: https://github.com/apache/hive/pull/4279#discussion_r1183707833
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1297,8 +1297,12 @@ public boolean shouldOverwrite(org.apache.hadoop.hive.ql.metadata.Table mTable,
public Boolean hasAppendsOnly(org.apache.hadoop.hive.ql.metadata.Table hmsTable, SnapshotContext since) {
TableDesc tableDesc = Utilities.getTableDesc(hmsTable);
Table table = IcebergTableUtil.getTable(conf, tableDesc.getProperties());
- boolean foundSince = false;
- for (Snapshot snapshot : table.snapshots()) {
+ return hasAppendsOnly(table.snapshots(), since);
+ }
+
+ public Boolean hasAppendsOnly(Iterable<Snapshot> snapshots, SnapshotContext since) {
+ boolean foundSince = since == null;
Review Comment:
Maybe it's only me, but the name of this variable and the way it is used for two different things (is since non-null, and did we find the snapshot) is quite confusing. I wouldeither rename it, or split to two variables.
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1297,8 +1297,12 @@ public boolean shouldOverwrite(org.apache.hadoop.hive.ql.metadata.Table mTable,
public Boolean hasAppendsOnly(org.apache.hadoop.hive.ql.metadata.Table hmsTable, SnapshotContext since) {
TableDesc tableDesc = Utilities.getTableDesc(hmsTable);
Table table = IcebergTableUtil.getTable(conf, tableDesc.getProperties());
- boolean foundSince = false;
- for (Snapshot snapshot : table.snapshots()) {
+ return hasAppendsOnly(table.snapshots(), since);
+ }
+
+ public Boolean hasAppendsOnly(Iterable<Snapshot> snapshots, SnapshotContext since) {
Review Comment:
If this is used only by the tests, please add the @VisibleForTests annotation to mark it explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org