You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/04/18 13:48:17 UTC
[Apache Bloodhound] #36: Apply correct Bootstrap classes to buttons
#36: Apply correct Bootstrap classes to buttons
-------------------------+-------------------------------------
Reporter: jdreimann | Owner: nobody
Type: enhancement | Status: new
Priority: critical | Milestone: RC1 for initial release
Component: ui design | Version:
Keywords: |
-------------------------+-------------------------------------
For buttons in Bloodhound to display with the correct Bootstrap styles,
the following changes have to be implemented (tag .class #id like in CSS):
{{{
.attachments input -> add class="btn"
.buttons input -> add class="btn"
input class="inlinebutton" -> replace "inlinebutton" with "btn"
div.inlinebuttons input -> add class="btn"
}}}
I believe that covers all buttons in the default installation.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/36>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to
buttons
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#36: Apply correct Bootstrap classes to buttons
--------------------------+-------------------------------------
Reporter: jdreimann | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: RC1 for initial release
Component: ui design | Version:
Resolution: | Keywords:
--------------------------+-------------------------------------
Comment (by gjm):
With the approach of #88, we could also cover some of the unconverted
cases highlighted in this ticket.
For instance, could the following rules help to convert INPUT.buttons
elements and some of the expected structure associated with buttons?
{{{
#!xml
<py:match path="div[@class='buttons']//input[@type='submit' and
not(contains(@class,'btn'))]" once="false" buffer="true">
<input py:attrs="add_classes(select('@*'), 'btn')">
${select('*|text()|comment()')}
</input>
</py:match>
<py:match path="div[@class='buttons']/form/div" once="false"
buffer="true">
<div py:attrs="add_classes(select('@*'), 'btn-group')">
${select('*|text()|comment()')}
</div>
</py:match>
<py:match path="div[@class='buttons']" once="false" buffer="true">
<div py:attrs="add_classes(select('@*'), 'btn-toolbar')">
${select('*|text()|comment()')}
</div>
</py:match>
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/36#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to
buttons
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#36: Apply correct Bootstrap classes to buttons
--------------------------+-------------------------------------
Reporter: jdreimann | Owner: gjm
Type: enhancement | Status: assigned
Priority: critical | Milestone: RC1 for initial release
Component: ui design | Version:
Resolution: | Keywords:
--------------------------+-------------------------------------
Changes (by gjm):
* owner: nobody => gjm
* status: new => assigned
Comment:
Given that these changes are mostly looked after by other related tickets,
I am going to re-purpose this ticket for reviewing the current classes on
buttons.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/36#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to
buttons
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#36: Apply correct Bootstrap classes to buttons
--------------------------+-------------------------------------
Reporter: jdreimann | Owner: gjm
Type: enhancement | Status: closed
Priority: major | Milestone: RC1 for initial release
Component: ui design | Version:
Resolution: fixed | Keywords:
--------------------------+-------------------------------------
Changes (by gjm):
* status: assigned => closed
* resolution: => fixed
Comment:
Raised #137 to allow the closure of this ticket.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/36#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to
buttons
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#36: Apply correct Bootstrap classes to buttons
--------------------------+-------------------------------------
Reporter: jdreimann | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: RC1 for initial release
Component: ui design | Version:
Resolution: | Keywords:
--------------------------+-------------------------------------
Changes (by gjm):
* priority: critical => major
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/36#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to
buttons
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#36: Apply correct Bootstrap classes to buttons
--------------------------+-------------------------------------
Reporter: jdreimann | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: RC1 for initial release
Component: ui design | Version:
Resolution: | Keywords:
--------------------------+-------------------------------------
Comment (by olemis):
[attachment:t36_r1342840_generic_bootstrap_button.diff Attached patch] (
against r1342840 ) illustrates how to do the same thing by reusing
[comment:ticket:88:6 stream filters as explained in #88].
There's also something I wanted to say . Quite often it happens that
`DIV`s like `.buttons` include `input[@type = 'hidden']` fields . This has
some impact on the look and feel , especially odd borders for `btn-
group`s . Hence I suggest to ignore the replacement for
`div[@class='buttons']/form/div` => `DIV.btn-group` .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/36#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to buttons
Posted by Joe Dreimann <jo...@wandisco.com>.
Yes, that's what I meant - the templates need to be changed so that the correct classes get applied. Apologies if that wasn't clear. The list in the ticket is just a list of current buttons with the wrong class, or no class applied.
- Joe
________________________
@jdreimann - Twitter
Sent from my phone
On 22 Apr 2012, at 05:12, Olemis Lang <ol...@gmail.com> wrote:
> oh !
>
> IMO the best way to get this done is to override default Trac
> templates rather than changing CSS rules ... especially now that
> legacy styles will be dismissed (as mentioned in #39 ;)
>
> On 4/18/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
>> #36: Apply correct Bootstrap classes to buttons
>> -------------------------+-------------------------------------
>> Reporter: jdreimann | Owner: nobody
>> Type: enhancement | Status: new
>> Priority: critical | Milestone: RC1 for initial release
>> Component: ui design | Version:
>> Keywords: |
>> -------------------------+-------------------------------------
>> For buttons in Bloodhound to display with the correct Bootstrap styles,
>> the following changes have to be implemented (tag .class #id like in CSS):
>>
>> {{{
>> .attachments input -> add class="btn"
>> .buttons input -> add class="btn"
>> input class="inlinebutton" -> replace "inlinebutton" with "btn"
>> div.inlinebuttons input -> add class="btn"
>> }}}
>>
>> I believe that covers all buttons in the default installation.
>>
>> --
>> Ticket URL: <https://issues.apache.org/bloodhound/ticket/36>
>> Apache Bloodhound <https://issues.apache.org/bloodhound/>
>> The Apache Bloodhound (incubating) issue tracker
>>
>
>
> --
> Regards,
>
> Olemis.
>
> Blog ES: http://simelo-es.blogspot.com/
> Blog EN: http://simelo-en.blogspot.com/
>
> Featured article:
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to buttons
Posted by Olemis Lang <ol...@gmail.com>.
oh !
IMO the best way to get this done is to override default Trac
templates rather than changing CSS rules ... especially now that
legacy styles will be dismissed (as mentioned in #39 ;)
On 4/18/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
> #36: Apply correct Bootstrap classes to buttons
> -------------------------+-------------------------------------
> Reporter: jdreimann | Owner: nobody
> Type: enhancement | Status: new
> Priority: critical | Milestone: RC1 for initial release
> Component: ui design | Version:
> Keywords: |
> -------------------------+-------------------------------------
> For buttons in Bloodhound to display with the correct Bootstrap styles,
> the following changes have to be implemented (tag .class #id like in CSS):
>
> {{{
> .attachments input -> add class="btn"
> .buttons input -> add class="btn"
> input class="inlinebutton" -> replace "inlinebutton" with "btn"
> div.inlinebuttons input -> add class="btn"
> }}}
>
> I believe that covers all buttons in the default installation.
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/36>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound (incubating) issue tracker
>
--
Regards,
Olemis.
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to
buttons
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#36: Apply correct Bootstrap classes to buttons
--------------------------+-------------------------------------
Reporter: jdreimann | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: RC1 for initial release
Component: ui design | Version:
Resolution: | Keywords:
--------------------------+-------------------------------------
Comment (by gjm):
r1344827 correcting a related issue of the file attachment not having the
file icon - converted <input> to <button>
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/36#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to
buttons
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#36: Apply correct Bootstrap classes to buttons
--------------------------+-------------------------------------
Reporter: jdreimann | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: RC1 for initial release
Component: ui design | Version:
Resolution: | Keywords:
--------------------------+-------------------------------------
Comment (by gjm):
r1361192 removing the remaining bootstrap classes associated with button
colours in the templates.
Exceptions to the above are the Search and quick ticket button. Some may
come back but I will insist that there should be justification and
consistency if this happens.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/36#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to
buttons
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#36: Apply correct Bootstrap classes to buttons
--------------------------+-------------------------------------
Reporter: jdreimann | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: RC1 for initial release
Component: ui design | Version:
Resolution: | Keywords:
--------------------------+-------------------------------------
Comment (by gjm):
r1352078 wiki view template now a bit less colourful and uses button
elements instead of inputs for consistent alignment
r1352083 makes wiki edit form buttons a consistent height (not changing to
button elements this time)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/36#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #36: Apply correct Bootstrap classes to
buttons
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#36: Apply correct Bootstrap classes to buttons
--------------------------+-------------------------------------
Reporter: jdreimann | Owner: gjm
Type: enhancement | Status: assigned
Priority: major | Milestone: RC1 for initial release
Component: ui design | Version:
Resolution: | Keywords:
--------------------------+-------------------------------------
Comment (by gjm):
r1345140 corrects the same related issue in the milestone view to give
icons to the buttons
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/36#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker