You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2017/04/21 00:08:05 UTC

Review Request 58598: RANGER-1531: Good coding practice while parsing XML documents in Ranger -- for ranger 0.7 branch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58598/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1531
    https://issues.apache.org/jira/browse/RANGER-1531


Repository: ranger


Description
-------

Added code to set "FEATURE_SECURE_PROCESSING" property to true for both XML document factory as well as for Transformer Factory.


Diffs
-----

  agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 8fee099 
  security-admin/src/main/java/org/apache/ranger/common/XMLPropertiesUtil.java 29fc78a 


Diff: https://reviews.apache.org/r/58598/diff/1/


Testing
-------

Confirmed all the existing unit tests ran successfully.


Thanks,

Sailaja Polavarapu


Re: Review Request 58598: RANGER-1531: Good coding practice while parsing XML documents in Ranger -- for ranger 0.7 branch

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58598/#review172605
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On April 21, 2017, 12:08 a.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58598/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 12:08 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1531
>     https://issues.apache.org/jira/browse/RANGER-1531
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added code to set "FEATURE_SECURE_PROCESSING" property to true for both XML document factory as well as for Transformer Factory.
> 
> 
> Diffs
> -----
> 
>   agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 8fee099 
>   security-admin/src/main/java/org/apache/ranger/common/XMLPropertiesUtil.java 29fc78a 
> 
> 
> Diff: https://reviews.apache.org/r/58598/diff/1/
> 
> 
> Testing
> -------
> 
> Confirmed all the existing unit tests ran successfully.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Re: Review Request 58598: RANGER-1531: Good coding practice while parsing XML documents in Ranger -- for ranger 0.7 branch

Posted by Sailaja Polavarapu <sp...@hortonworks.com>.

> On April 21, 2017, 8:10 a.m., Colm O hEigeartaigh wrote:
> > My patch only applied to master, so go ahead and apply this to 0.7

Thanks Colm.


- Sailaja


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58598/#review172604
-----------------------------------------------------------


On April 21, 2017, 12:08 a.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58598/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 12:08 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1531
>     https://issues.apache.org/jira/browse/RANGER-1531
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added code to set "FEATURE_SECURE_PROCESSING" property to true for both XML document factory as well as for Transformer Factory.
> 
> 
> Diffs
> -----
> 
>   agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 8fee099 
>   security-admin/src/main/java/org/apache/ranger/common/XMLPropertiesUtil.java 29fc78a 
> 
> 
> Diff: https://reviews.apache.org/r/58598/diff/1/
> 
> 
> Testing
> -------
> 
> Confirmed all the existing unit tests ran successfully.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Re: Review Request 58598: RANGER-1531: Good coding practice while parsing XML documents in Ranger -- for ranger 0.7 branch

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58598/#review172604
-----------------------------------------------------------



My patch only applied to master, so go ahead and apply this to 0.7

- Colm O hEigeartaigh


On April 21, 2017, 12:08 a.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58598/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 12:08 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1531
>     https://issues.apache.org/jira/browse/RANGER-1531
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added code to set "FEATURE_SECURE_PROCESSING" property to true for both XML document factory as well as for Transformer Factory.
> 
> 
> Diffs
> -----
> 
>   agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 8fee099 
>   security-admin/src/main/java/org/apache/ranger/common/XMLPropertiesUtil.java 29fc78a 
> 
> 
> Diff: https://reviews.apache.org/r/58598/diff/1/
> 
> 
> Testing
> -------
> 
> Confirmed all the existing unit tests ran successfully.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>