You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/11 07:46:21 UTC

[GitHub] [nuttx] W-Mai opened a new pull request, #8078: sim/posix/sim_linuxspi.c: fix select not work and incorrect behaviour

W-Mai opened a new pull request, #8078:
URL: https://github.com/apache/nuttx/pull/8078

   ## Summary
   
   Fixed missing `SPI_SELECT` method and incorrect sending behavior in sim_linuxspi
   
   ## Impact
   
   N/A
   
   ## Testing
   
   N/A
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on pull request #8078: sim/posix/sim_linuxspi.c: fix select not work and incorrect behaviour

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #8078:
URL: https://github.com/apache/nuttx/pull/8078#issuecomment-1378381889

   Please squash to a single commit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8078: sim/posix/sim_linuxspi.c: fix select not work and incorrect behaviour

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #8078:
URL: https://github.com/apache/nuttx/pull/8078#discussion_r1066677756


##########
arch/sim/src/sim/posix/sim_linuxspi.c:
##########
@@ -191,6 +191,26 @@ static int linux_spi_lock(struct spi_dev_s *dev, bool lock)
 static void linux_spi_select(struct spi_dev_s *dev, uint32_t devid,
                              bool selected)
 {
+  if (selected == false)

Review Comment:
   ```suggestion
     if (!selected)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] W-Mai commented on pull request #8078: sim/posix/sim_linuxspi.c: fix select not work and incorrect behaviour

Posted by GitBox <gi...@apache.org>.
W-Mai commented on PR #8078:
URL: https://github.com/apache/nuttx/pull/8078#issuecomment-1378390967

   > Please squash to a single commit
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8078: sim/posix/sim_linuxspi.c: fix select not work and incorrect behaviour

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8078:
URL: https://github.com/apache/nuttx/pull/8078


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on pull request #8078: sim/posix/sim_linuxspi.c: fix select not work and incorrect behaviour

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #8078:
URL: https://github.com/apache/nuttx/pull/8078#issuecomment-1380778987

   Please fix the build


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org