You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by "Wan Kun (Jira)" <ji...@apache.org> on 2019/11/30 05:18:00 UTC
[jira] [Commented] (GRIFFIN-307) Deprecating regex based filtering
with Enum
[ https://issues.apache.org/jira/browse/GRIFFIN-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985261#comment-16985261 ]
Wan Kun commented on GRIFFIN-307:
---------------------------------
Hi,[~tushar.patil]
Could you submit a PR, and we can compare the difference.
Thanks.
> Deprecating regex based filtering with Enum
> ---------------------------------------------
>
> Key: GRIFFIN-307
> URL: https://issues.apache.org/jira/browse/GRIFFIN-307
> Project: Griffin
> Issue Type: Improvement
> Reporter: Tushar
> Priority: Major
>
> All the predefined DQTypes, DSLTypes, FlattenType, OutputType, ProcessType, SinkType and WriteMode are compared with config using a regex-based approach. This will make unnecessary overhead in terms of execution time and maintainability.
> To fix this we should use a predefined enum based approach than regex based.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)