[GitHub] betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap
URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180899636
 
 

 ##########
 File path: superset/assets/javascripts/modules/colors.js
 ##########
 @@ -122,6 +122,42 @@ export const spectrums = {
     '#FAFAFA',
     '#666666',
   ],
+  greens: [
+    '#ffffcc',
+    '#78c679',
+    '#006837',
+  ],
+  purples: [
+    '#f2f0f7',
+    '#9e9ac8',
+    '#54278f',
+  ],
+  oranges: [
+    '#fef0d9',
+    '#fc8d59',
+    '#b30000',
+  ],
+  red_yellow_blue: [
+    '#d7191c',
+    '#fdae61',
+    '#ffffbf',
+    '#abd9e9',
+    '#2c7bb6',
+  ],
+  brown_white_green: [
+    '#a6611a',
+    '#dfc27d',
+    '#f5f5f5',
+    '#80cdc1',
+    '#018571',
+  ],
+  purple_white_green: [
 
 Review comment:
   I've seen some functions in Python (matplotlib perhaps?) where you can interpolate between colors. It would be cool to have something similar here, if it exists in Javascript (something [like this](https://www.npmjs.com/package/color-interpolate)). Imagine:
   
   ```javascript
   const brown = '#a6611a';
   const white = '#f5f5f5';
   const green = '#018571';
   ...
   const brown_white_green: interpolate([brown, white, green], 5),
   ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services