[GitHub] [arrow] nealrichardson commented on a change in pull request #10889: [WIP] Try LTO again

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #10889:
URL: https://github.com/apache/arrow/pull/10889#discussion_r684240294



##########
File path: r/tools/nixlibs.R
##########
@@ -328,20 +328,25 @@ build_libarrow <- function(src_dir, dst_dir) {
     # CXXFLAGS = R_CMD_config("CXX11FLAGS"), # We don't want the same debug symbols
     AR = R_CMD_config("AR"),
     RANLIB = R_CMD_config("RANLIB"),
-    LDFLAGS = R_CMD_config("LDFLAGS"),
-    CMAKE_CXX_COMPILER_AR = R_CMD_config("LDFLAGS")
+    LDFLAGS = R_CMD_config("LDFLAGS")
   )
   env_vars <- paste0(names(env_var_list), '="', env_var_list, '"', collapse = " ")
   env_vars <- with_s3_support(env_vars)
   env_vars <- with_mimalloc(env_vars)
-  if (tolower(Sys.info()[["sysname"]]) %in% "sunos") {
+  if (tolower(Sys.info()[["sysname"]]) %in% "sunos" || grepl("-flto", env_var_list[["LDFLAGS"]])) {

Review comment:
       Maybe, but I think this is where it matters, this is what gets used in the link step right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org