You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by su...@apache.org on 2022/10/08 15:31:45 UTC

[shardingsphere] branch master updated: Remove useless throws for ClusterPersistRepository (#21398)

This is an automated email from the ASF dual-hosted git repository.

sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 0c66b8166db Remove useless throws for ClusterPersistRepository (#21398)
0c66b8166db is described below

commit 0c66b8166dbcc2788ee15da5d8e115eba98d0451
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sat Oct 8 23:31:34 2022 +0800

    Remove useless throws for ClusterPersistRepository (#21398)
---
 .../spring/namespace/fixture/FixtureClusterPersistRepository.java  | 7 +------
 .../coordinator/fixture/ClusterPersistRepositoryFixture.java       | 7 +------
 .../process/ProcessListClusterPersistRepositoryFixture.java        | 3 +--
 .../mode/repository/cluster/consul/ConsulRepository.java           | 2 +-
 .../mode/repository/cluster/etcd/EtcdRepository.java               | 2 +-
 .../mode/repository/cluster/nacos/NacosRepository.java             | 2 +-
 .../repository/cluster/zookeeper/CuratorZookeeperRepository.java   | 2 +-
 .../proxy/fixture/ClusterPersistRepositoryFixture.java             | 5 +----
 .../driver/fixture/TestClusterPersistRepository.java               | 7 +------
 9 files changed, 9 insertions(+), 28 deletions(-)

diff --git a/jdbc/spring/core/shardingsphere-jdbc-core-spring-namespace/src/test/java/org/apache/shardingsphere/spring/namespace/fixture/FixtureClusterPersistRepository.java b/jdbc/spring/core/shardingsphere-jdbc-core-spring-namespace/src/test/java/org/apache/shardingsphere/spring/namespace/fixture/FixtureClusterPersistRepository.java
index 0fde811f0cc..d2d0c720541 100644
--- a/jdbc/spring/core/shardingsphere-jdbc-core-spring-namespace/src/test/java/org/apache/shardingsphere/spring/namespace/fixture/FixtureClusterPersistRepository.java
+++ b/jdbc/spring/core/shardingsphere-jdbc-core-spring-namespace/src/test/java/org/apache/shardingsphere/spring/namespace/fixture/FixtureClusterPersistRepository.java
@@ -45,12 +45,10 @@ public final class FixtureClusterPersistRepository implements ClusterPersistRepo
     
     @Override
     public void addCacheData(final String cachePath) {
-    
     }
     
     @Override
     public void evictCacheData(final String cachePath) {
-    
     }
     
     @Override
@@ -60,12 +58,10 @@ public final class FixtureClusterPersistRepository implements ClusterPersistRepo
     
     @Override
     public void executeInLeader(final String key, final LeaderExecutionCallback callback) {
-    
     }
     
     @Override
-    public void executeInTransaction(final List<TransactionOperation> transactionOperations) throws Exception {
-    
+    public void executeInTransaction(final List<TransactionOperation> transactionOperations) {
     }
     
     @Override
@@ -90,7 +86,6 @@ public final class FixtureClusterPersistRepository implements ClusterPersistRepo
     
     @Override
     public void update(final String key, final String value) {
-    
     }
     
     @Override
diff --git a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/fixture/ClusterPersistRepositoryFixture.java b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/fixture/ClusterPersistRepositoryFixture.java
index fde68735270..56329725aab 100644
--- a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/fixture/ClusterPersistRepositoryFixture.java
+++ b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/fixture/ClusterPersistRepositoryFixture.java
@@ -39,12 +39,10 @@ public final class ClusterPersistRepositoryFixture implements ClusterPersistRepo
     
     @Override
     public void addCacheData(final String cachePath) {
-    
     }
     
     @Override
     public void evictCacheData(final String cachePath) {
-    
     }
     
     @Override
@@ -54,12 +52,10 @@ public final class ClusterPersistRepositoryFixture implements ClusterPersistRepo
     
     @Override
     public void executeInLeader(final String key, final LeaderExecutionCallback callback) {
-    
     }
     
     @Override
-    public void executeInTransaction(final List<TransactionOperation> transactionOperations) throws Exception {
-    
+    public void executeInTransaction(final List<TransactionOperation> transactionOperations) {
     }
     
     @Override
@@ -83,7 +79,6 @@ public final class ClusterPersistRepositoryFixture implements ClusterPersistRepo
     
     @Override
     public void update(final String key, final String value) {
-    
     }
     
     @Override
diff --git a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/registry/process/ProcessListClusterPersistRepositoryFixture.java b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/registry/process/ProcessListClusterPersistRepositoryFixture.java
index beb4a5ff946..e2312d09d09 100644
--- a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/registry/process/ProcessListClusterPersistRepositoryFixture.java
+++ b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/registry/process/ProcessListClusterPersistRepositoryFixture.java
@@ -62,8 +62,7 @@ public final class ProcessListClusterPersistRepositoryFixture implements Cluster
     }
     
     @Override
-    public void executeInTransaction(final List<TransactionOperation> transactionOperations) throws Exception {
-    
+    public void executeInTransaction(final List<TransactionOperation> transactionOperations) {
     }
     
     @Override
diff --git a/mode/type/cluster/repository/provider/consul/src/main/java/org/apache/shardingsphere/mode/repository/cluster/consul/ConsulRepository.java b/mode/type/cluster/repository/provider/consul/src/main/java/org/apache/shardingsphere/mode/repository/cluster/consul/ConsulRepository.java
index c649a861b57..a29290703e4 100644
--- a/mode/type/cluster/repository/provider/consul/src/main/java/org/apache/shardingsphere/mode/repository/cluster/consul/ConsulRepository.java
+++ b/mode/type/cluster/repository/provider/consul/src/main/java/org/apache/shardingsphere/mode/repository/cluster/consul/ConsulRepository.java
@@ -90,7 +90,7 @@ public class ConsulRepository implements ClusterPersistRepository {
     }
     
     @Override
-    public void executeInTransaction(final List<TransactionOperation> transactionOperations) throws Exception {
+    public void executeInTransaction(final List<TransactionOperation> transactionOperations) {
         // TODO
     }
     
diff --git a/mode/type/cluster/repository/provider/etcd/src/main/java/org/apache/shardingsphere/mode/repository/cluster/etcd/EtcdRepository.java b/mode/type/cluster/repository/provider/etcd/src/main/java/org/apache/shardingsphere/mode/repository/cluster/etcd/EtcdRepository.java
index 301d235a863..573f1652f6a 100644
--- a/mode/type/cluster/repository/provider/etcd/src/main/java/org/apache/shardingsphere/mode/repository/cluster/etcd/EtcdRepository.java
+++ b/mode/type/cluster/repository/provider/etcd/src/main/java/org/apache/shardingsphere/mode/repository/cluster/etcd/EtcdRepository.java
@@ -96,7 +96,7 @@ public final class EtcdRepository implements ClusterPersistRepository {
     }
     
     @Override
-    public void executeInTransaction(final List<TransactionOperation> transactionOperations) throws Exception {
+    public void executeInTransaction(final List<TransactionOperation> transactionOperations) {
         // TODO
     }
     
diff --git a/mode/type/cluster/repository/provider/nacos/src/main/java/org/apache/shardingsphere/mode/repository/cluster/nacos/NacosRepository.java b/mode/type/cluster/repository/provider/nacos/src/main/java/org/apache/shardingsphere/mode/repository/cluster/nacos/NacosRepository.java
index d9bb04f0977..19339b12fca 100644
--- a/mode/type/cluster/repository/provider/nacos/src/main/java/org/apache/shardingsphere/mode/repository/cluster/nacos/NacosRepository.java
+++ b/mode/type/cluster/repository/provider/nacos/src/main/java/org/apache/shardingsphere/mode/repository/cluster/nacos/NacosRepository.java
@@ -102,7 +102,7 @@ public final class NacosRepository implements ClusterPersistRepository {
     }
     
     @Override
-    public void executeInTransaction(final List<TransactionOperation> transactionOperations) throws Exception {
+    public void executeInTransaction(final List<TransactionOperation> transactionOperations) {
         // TODO
     }
     
diff --git a/mode/type/cluster/repository/provider/zookeeper-curator/src/main/java/org/apache/shardingsphere/mode/repository/cluster/zookeeper/CuratorZookeeperRepository.java b/mode/type/cluster/repository/provider/zookeeper-curator/src/main/java/org/apache/shardingsphere/mode/repository/cluster/zookeeper/CuratorZookeeperRepository.java
index 169a566fe11..60759a0974e 100644
--- a/mode/type/cluster/repository/provider/zookeeper-curator/src/main/java/org/apache/shardingsphere/mode/repository/cluster/zookeeper/CuratorZookeeperRepository.java
+++ b/mode/type/cluster/repository/provider/zookeeper-curator/src/main/java/org/apache/shardingsphere/mode/repository/cluster/zookeeper/CuratorZookeeperRepository.java
@@ -164,7 +164,7 @@ public final class CuratorZookeeperRepository implements ClusterPersistRepositor
     }
     
     @Override
-    public void executeInTransaction(final List<TransactionOperation> transactionOperations) throws Exception {
+    public void executeInTransaction(final List<TransactionOperation> transactionOperations) {
         // TODO
     }
     
diff --git a/proxy/bootstrap/src/test/java/org/apache/shardingsphere/proxy/fixture/ClusterPersistRepositoryFixture.java b/proxy/bootstrap/src/test/java/org/apache/shardingsphere/proxy/fixture/ClusterPersistRepositoryFixture.java
index a0b2c322ccf..ef1dc6c5ef1 100644
--- a/proxy/bootstrap/src/test/java/org/apache/shardingsphere/proxy/fixture/ClusterPersistRepositoryFixture.java
+++ b/proxy/bootstrap/src/test/java/org/apache/shardingsphere/proxy/fixture/ClusterPersistRepositoryFixture.java
@@ -58,12 +58,10 @@ public final class ClusterPersistRepositoryFixture implements ClusterPersistRepo
     
     @Override
     public void executeInLeader(final String key, final LeaderExecutionCallback callback) {
-    
     }
     
     @Override
-    public void executeInTransaction(final List<TransactionOperation> transactionOperations) throws Exception {
-    
+    public void executeInTransaction(final List<TransactionOperation> transactionOperations) {
     }
     
     @Override
@@ -88,7 +86,6 @@ public final class ClusterPersistRepositoryFixture implements ClusterPersistRepo
     
     @Override
     public void update(final String key, final String value) {
-    
     }
     
     @Override
diff --git a/test/integration-driver-test/src/test/java/org/apache/shardingsphere/driver/fixture/TestClusterPersistRepository.java b/test/integration-driver-test/src/test/java/org/apache/shardingsphere/driver/fixture/TestClusterPersistRepository.java
index c82c0c0732a..b15d3fb353e 100644
--- a/test/integration-driver-test/src/test/java/org/apache/shardingsphere/driver/fixture/TestClusterPersistRepository.java
+++ b/test/integration-driver-test/src/test/java/org/apache/shardingsphere/driver/fixture/TestClusterPersistRepository.java
@@ -45,12 +45,10 @@ public final class TestClusterPersistRepository implements ClusterPersistReposit
     
     @Override
     public void addCacheData(final String cachePath) {
-    
     }
     
     @Override
     public void evictCacheData(final String cachePath) {
-    
     }
     
     @Override
@@ -60,12 +58,10 @@ public final class TestClusterPersistRepository implements ClusterPersistReposit
     
     @Override
     public void executeInLeader(final String key, final LeaderExecutionCallback callback) {
-    
     }
     
     @Override
-    public void executeInTransaction(final List<TransactionOperation> transactionOperations) throws Exception {
-    
+    public void executeInTransaction(final List<TransactionOperation> transactionOperations) {
     }
     
     @Override
@@ -90,7 +86,6 @@ public final class TestClusterPersistRepository implements ClusterPersistReposit
     
     @Override
     public void update(final String key, final String value) {
-    
     }
     
     @Override