You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/11/07 13:19:33 UTC
[GitHub] [lucene] donnerpeter opened a new pull request, #11904: [hunspell] speed up WordFormGenerator
donnerpeter opened a new pull request, #11904:
URL: https://github.com/apache/lucene/pull/11904
Various minor optimizations to reduce allocations and unnecessary checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] donnerpeter commented on a diff in pull request #11904: [hunspell] speed up WordFormGenerator
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on code in PR #11904:
URL: https://github.com/apache/lucene/pull/11904#discussion_r1015510285
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/AffixCondition.java:
##########
@@ -31,8 +31,30 @@
*/
interface AffixCondition {
String ALWAYS_TRUE_KEY = ".*";
- AffixCondition ALWAYS_TRUE = (word, offset, length) -> true;
Review Comment:
Before the delegation, the default method calls String.toCharArray, and I've seen it in the profiler, so apparently JIT doesn't always remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #11904: [hunspell] speed up WordFormGenerator
Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #11904:
URL: https://github.com/apache/lucene/pull/11904#discussion_r1015435007
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/AffixCondition.java:
##########
@@ -31,8 +31,30 @@
*/
interface AffixCondition {
String ALWAYS_TRUE_KEY = ".*";
- AffixCondition ALWAYS_TRUE = (word, offset, length) -> true;
Review Comment:
Is there really a performance difference here? Seems like c2 should be smart enough to fold the lambda/ default method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] donnerpeter merged pull request #11904: [hunspell] speed up WordFormGenerator
Posted by GitBox <gi...@apache.org>.
donnerpeter merged PR #11904:
URL: https://github.com/apache/lucene/pull/11904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org