You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/14 09:09:18 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #39061: [WIP][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
MaxGekk opened a new pull request, #39061:
URL: https://github.com/apache/spark/pull/39061
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39061: [SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1049654384
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -398,15 +398,9 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
}
}
case e: Attribute if groupingExprs.isEmpty =>
Review Comment:
Seems `e` is no longer used, replace with `_` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39061: [SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #39061:
URL: https://github.com/apache/spark/pull/39061#issuecomment-1354320342
Merging to master. Thank you, @itholic @LuciferYang for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39061: [WIP][SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1048886878
##########
sql/core/src/test/resources/sql-tests/results/group-by.sql.out:
##########
@@ -355,10 +354,9 @@ struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
- "errorClass" : "_LEGACY_ERROR_TEMP_2422",
+ "errorClass" : "AGGREGATION_WITHOUT_GROUP_BY",
"messageParameters" : {
- "aggExprs" : "()",
- "sqlExpr" : "id"
+ "aggExprs" : ""
Review Comment:
Here is the case when there are no aggregations at all:
```sql
SELECT id FROM range(10) HAVING id > 0
```
@srielau How about just `MISSING_GROUP_BY` or `GROUP_BY_NOT_FOUND`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #39061: [SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #39061: [SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
URL: https://github.com/apache/spark/pull/39061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39061: [WIP][SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1048703232
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -496,6 +496,11 @@
],
"sqlState" : "42000"
},
+ "GROUPING_EXPRESSIONS_NOT_FOUND" : {
+ "message" : [
+ "Not found any GROUP BY expressions, and <sqlExpr> is not an aggregate function. Wrap <aggExprs> by windowing function(s) or wrap <sqlExpr> by `first()` (or `first_value()`) if you don't care which value you get."
+ ]
+ },
Review Comment:
> My money is on forgetting the GROUP BY clause....
Highly likely, you are right. Let me following your proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39061: [SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1050420279
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -397,16 +397,10 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
messageParameters = Map("sqlExpr" -> expr.sql))
}
}
- case e: Attribute if groupingExprs.isEmpty =>
- // Collect all [[AggregateExpressions]]s.
- val aggExprs = aggregateExprs.filter(_.collect {
- case a: AggregateExpression => a
- }.nonEmpty)
- e.failAnalysis(
- errorClass = "_LEGACY_ERROR_TEMP_2422",
- messageParameters = Map(
- "sqlExpr" -> e.sql,
- "aggExprs" -> aggExprs.map(_.sql).mkString("(", ", ", ")")))
+ case _: Attribute if groupingExprs.isEmpty =>
+ operator.failAnalysis(
+ errorClass = "MISSING_GROUP_BY",
+ messageParameters = Map.empty)
Review Comment:
Are there any reasons to do so in OSS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #39061: [WIP][SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
srielau commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1048617462
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -496,6 +496,11 @@
],
"sqlState" : "42000"
},
+ "GROUPING_EXPRESSIONS_NOT_FOUND" : {
+ "message" : [
+ "Not found any GROUP BY expressions, and <sqlExpr> is not an aggregate function. Wrap <aggExprs> by windowing function(s) or wrap <sqlExpr> by `first()` (or `first_value()`) if you don't care which value you get."
+ ]
+ },
Review Comment:
What is more likely? The user forgot the GROUP BY clause, the user forgot to aggregate the expression, or they meant to use window functions? My money is on forgetting the GROUP BY clause....
How about:
GROUPING_EXPRESSION_WITHOUT_GROUP_BY
The query including grouping expression \<groupingExpr\> and aggregate expressions \<aggExprs\> does not include a GROUP BY clause. Add "GROUP BY \<groupingExpr\>", aggregate \<groupingExpr\>, or turn the \<aggExprs\> into window functions using OVER clauses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39061: [WIP][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1048437947
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -496,6 +496,11 @@
],
"sqlState" : "42000"
},
+ "GROUPING_EXPRESSIONS_NOT_FOUND" : {
+ "message" : [
+ "Not found any GROUP BY expressions, and <sqlExpr> is not an aggregate function. Wrap <aggExprs> by windowing function(s) or wrap <sqlExpr> by `first()` (or `first_value()`) if you don't care which value you get."
+ ]
+ },
Review Comment:
@srielau Are you ok with the error class and message format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39061: [WIP][SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1048792097
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -496,6 +496,11 @@
],
"sqlState" : "42000"
},
+ "GROUPING_EXPRESSIONS_NOT_FOUND" : {
+ "message" : [
+ "Not found any GROUP BY expressions, and <sqlExpr> is not an aggregate function. Wrap <aggExprs> by windowing function(s) or wrap <sqlExpr> by `first()` (or `first_value()`) if you don't care which value you get."
+ ]
+ },
Review Comment:
@srielau I think this name `GROUPING_EXPRESSION_WITHOUT_GROUP_BY` might confuse. How about `AGGREGATION_WITHOUT_GROUP_BY`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39061: [WIP][SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1048886878
##########
sql/core/src/test/resources/sql-tests/results/group-by.sql.out:
##########
@@ -355,10 +354,9 @@ struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
- "errorClass" : "_LEGACY_ERROR_TEMP_2422",
+ "errorClass" : "AGGREGATION_WITHOUT_GROUP_BY",
"messageParameters" : {
- "aggExprs" : "()",
- "sqlExpr" : "id"
+ "aggExprs" : ""
Review Comment:
Here is the case when there are no aggregations at all:
```sql
SELECT id FROM range(10) HAVING id > 0
```
@srielau How about just `MISSING_GROUP_BY`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #39061: [WIP][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
srielau commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1048617462
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -496,6 +496,11 @@
],
"sqlState" : "42000"
},
+ "GROUPING_EXPRESSIONS_NOT_FOUND" : {
+ "message" : [
+ "Not found any GROUP BY expressions, and <sqlExpr> is not an aggregate function. Wrap <aggExprs> by windowing function(s) or wrap <sqlExpr> by `first()` (or `first_value()`) if you don't care which value you get."
+ ]
+ },
Review Comment:
What is more likely? The user forgot the GROUP BY clause, the user forgot to aggregate the expression, or they meant to use window functions? My money is on forgetting the GROUP BY clause....
How about:
GROUPING_EXPRESSION_WITHOUT_GROUP_BY
The query including grouping expression <groupingExpr> and aggregate expressions <aggExprs> does not include a GROUP BY clause. Add "GROUP BY <groupingExpr>", aggregate <groupingExpr>, or turn the <aggExprs> into window functions using OVER clauses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39061: [WIP][SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1048886878
##########
sql/core/src/test/resources/sql-tests/results/group-by.sql.out:
##########
@@ -355,10 +354,9 @@ struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
- "errorClass" : "_LEGACY_ERROR_TEMP_2422",
+ "errorClass" : "AGGREGATION_WITHOUT_GROUP_BY",
"messageParameters" : {
- "aggExprs" : "()",
- "sqlExpr" : "id"
+ "aggExprs" : ""
Review Comment:
Here is the case when there are no aggregations at all:
```sql
SELECT id FROM range(10) HAVING id > 0
```
How about just `MISSING_GROUP_BY`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39061: [SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #39061:
URL: https://github.com/apache/spark/pull/39061#issuecomment-1352725809
@srielau @itholic @cloud-fan @panbingkun @LuciferYang Please, review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39061: [SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1049986892
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -398,15 +398,9 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
}
}
case e: Attribute if groupingExprs.isEmpty =>
Review Comment:
replaced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39061: [SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1050278763
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -397,16 +397,10 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
messageParameters = Map("sqlExpr" -> expr.sql))
}
}
- case e: Attribute if groupingExprs.isEmpty =>
- // Collect all [[AggregateExpressions]]s.
- val aggExprs = aggregateExprs.filter(_.collect {
- case a: AggregateExpression => a
- }.nonEmpty)
- e.failAnalysis(
- errorClass = "_LEGACY_ERROR_TEMP_2422",
- messageParameters = Map(
- "sqlExpr" -> e.sql,
- "aggExprs" -> aggExprs.map(_.sql).mkString("(", ", ", ")")))
+ case _: Attribute if groupingExprs.isEmpty =>
+ operator.failAnalysis(
+ errorClass = "MISSING_GROUP_BY",
+ messageParameters = Map.empty)
Review Comment:
nit: can we clarify the type with `Map.empty[String, String]` To explicitly tell which types can come ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org