[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10685: [multistage] Decorrelate plan before optimizer

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on code in PR #10685:
URL: https://github.com/apache/pinot/pull/10685#discussion_r1176774515


##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -119,7 +119,11 @@ public static FilterContext getFilter(Expression thriftExpression) {
         return new FilterContext(FilterContext.Type.PREDICATE, null,
             new EqPredicate(getExpression(thriftExpression), getStringValue(RequestUtils.getLiteralExpression(true))));
       case LITERAL:
-        // TODO: Handle literals.
+        // Skip "WHERE true"

Review Comment:
   @Jackie-Jiang @walterddr 
   
   Somehow the sample query I added, after decorrelate, the parsed query will generate a predicate `"WHERE true"`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org