You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Ja...@rzf.fin-nrw.de on 2008/09/19 12:06:09 UTC
AW: svn commit: r697019 - in /ant/ivy/ivyde/trunk: org.apache.ivyde.eclipse/ org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cpcontainer/ test/ivy-base-dir/ test/ivy-base-dir/settings/ test/ivy-base-dir/src/
>Modified:
>ant/ivy/ivyde/trunk/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/
eclipse/cpcontainer/IvyClasspathContainerConfiguration.java
>@@ -480,14 +492,17 @@
> }
>
> if (file.lastModified() != ivySettingsLastModified) {
>- ivy = new Ivy();
>+ IvySettings ivySettings = new IvySettings();
>+ if (javaProject != null) {
>+
ivySettings.setBaseDir(javaProject.getProject().getLocation().toFile());
>+ }
> if (ivySettingsLastModified == -1) {
> Message.info("\n\n");
> } else {
> Message.info("\n\nIVYDE: ivysettings has changed,
configuring ivy again\n");
The info message completely in lower case?
Why just the two new lines when -1?
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: AW: AW: svn commit: r697019 - in /ant/ivy/ivyde/trunk: org.apache.ivyde.eclipse/ org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cpcontainer/ test/ivy-base-dir/ test/ivy-base-dir/settings/ test/ivy-base-dir/src/
Posted by Ja...@rzf.fin-nrw.de.
>> > I think it would be better to write
>> > Message.info("\n\nIVYDE: Ivy-settings has changed,
configuring Ivy again\n");
>> > Or is "ivysettings" a technical term?
>>
>> well, in Ivy's literature, I used to read about some "ivyconf", so
with the
>> new terminology, it becames "ivysettings". It looks understandable
for me.
>> But I don't have any objection to change every occurence of it into
"Ivy
>> settings".
>
>To me ivysettings is pretty obvious, at least when you know
>how Ivy settings
>are written. But Ivy settings would be fine too, I don't mind.
I am not so familiar with Ivy (yet). So if "ivysettings" is a common
technical term,
I would keep it as it is.
Thanks for clarification.
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: AW: AW: svn commit: r697019 - in /ant/ivy/ivyde/trunk: org.apache.ivyde.eclipse/ org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cpcontainer/ test/ivy-base-dir/ test/ivy-base-dir/settings/ test/ivy-base-dir/src/
Posted by Xavier Hanin <xa...@gmail.com>.
On Fri, Sep 19, 2008 at 2:16 PM, Nicolas Lalevée <nicolas.lalevee@hibnet.org
> wrote:
> Le vendredi 19 septembre 2008, Jan.Materne@rzf.fin-nrw.de a écrit :
> > >> > if (ivySettingsLastModified == -1) {
> > >> > Message.info("\n\n");
> > >> > } else {
> > >> > Message.info("\n\nIVYDE: ivysettings has changed,
> > >>
> > >> The info message completely in lower case?
> > >
> > >is there any worry about it ?
> >
> > Not really. But if you present a log message (like the Exception
> > strings)
> > I think it would be better to write
> > Message.info("\n\nIVYDE: Ivy-settings has changed, configuring
> > Ivy again\n");
> > Or is "ivysettings" a technical term?
>
> well, in Ivy's literature, I used to read about some "ivyconf", so with the
> new terminology, it becames "ivysettings". It looks understandable for me.
> But I don't have any objection to change every occurence of it into "Ivy
> settings".
To me ivysettings is pretty obvious, at least when you know how Ivy settings
are written. But Ivy settings would be fine too, I don't mind.
Xavier
>
>
> Nicolas
>
> >
> > >> Why just the two new lines when -1?
> > >
> > >The two new lines are I think because we are probably starting
> > >a new resolve
> > >session, so this need to be somehow visible.
> > >And -1 means that the file has not been loaded yet, so there
> > >is no reloading
> > >to log about.
> >
> > Ok, thanks
> >
> >
> > Jan
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> > For additional commands, e-mail: dev-help@ant.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
--
Xavier Hanin - Independent Java Consultant
BordeauxJUG co leader - http://www.bordeauxjug.org/
Blogger - http://xhab.blogspot.com/
Apache Ivy Creator - http://ant.apache.org/ivy/
Re: AW: AW: svn commit: r697019 - in /ant/ivy/ivyde/trunk: org.apache.ivyde.eclipse/ org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cpcontainer/ test/ivy-base-dir/ test/ivy-base-dir/settings/ test/ivy-base-dir/src/
Posted by Nicolas Lalevée <ni...@hibnet.org>.
Le vendredi 19 septembre 2008, Jan.Materne@rzf.fin-nrw.de a écrit :
> >> > if (ivySettingsLastModified == -1) {
> >> > Message.info("\n\n");
> >> > } else {
> >> > Message.info("\n\nIVYDE: ivysettings has changed,
> >>
> >> The info message completely in lower case?
> >
> >is there any worry about it ?
>
> Not really. But if you present a log message (like the Exception
> strings)
> I think it would be better to write
> Message.info("\n\nIVYDE: Ivy-settings has changed, configuring
> Ivy again\n");
> Or is "ivysettings" a technical term?
well, in Ivy's literature, I used to read about some "ivyconf", so with the
new terminology, it becames "ivysettings". It looks understandable for me.
But I don't have any objection to change every occurence of it into "Ivy
settings".
Nicolas
>
> >> Why just the two new lines when -1?
> >
> >The two new lines are I think because we are probably starting
> >a new resolve
> >session, so this need to be somehow visible.
> >And -1 means that the file has not been loaded yet, so there
> >is no reloading
> >to log about.
>
> Ok, thanks
>
>
> Jan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: AW: svn commit: r697019 - in /ant/ivy/ivyde/trunk: org.apache.ivyde.eclipse/ org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cpcontainer/ test/ivy-base-dir/ test/ivy-base-dir/settings/ test/ivy-base-dir/src/
Posted by Ja...@rzf.fin-nrw.de.
>> > if (ivySettingsLastModified == -1) {
>> > Message.info("\n\n");
>> > } else {
>> > Message.info("\n\nIVYDE: ivysettings has changed,
>>
>>
>> The info message completely in lower case?
>
>is there any worry about it ?
Not really. But if you present a log message (like the Exception
strings)
I think it would be better to write
Message.info("\n\nIVYDE: Ivy-settings has changed, configuring
Ivy again\n");
Or is "ivysettings" a technical term?
>
>> Why just the two new lines when -1?
>
>The two new lines are I think because we are probably starting
>a new resolve
>session, so this need to be somehow visible.
>And -1 means that the file has not been loaded yet, so there
>is no reloading
>to log about.
Ok, thanks
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: AW: svn commit: r697019 - in /ant/ivy/ivyde/trunk: org.apache.ivyde.eclipse/ org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cpcontainer/ test/ivy-base-dir/ test/ivy-base-dir/settings/ test/ivy-base-dir/src/
Posted by Nicolas Lalevée <ni...@hibnet.org>.
Le vendredi 19 septembre 2008, Jan.Materne@rzf.fin-nrw.de a écrit :
> >Modified:
> >ant/ivy/ivyde/trunk/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/
>
> eclipse/cpcontainer/IvyClasspathContainerConfiguration.java
>
> >@@ -480,14 +492,17 @@
> > }
> >
> > if (file.lastModified() != ivySettingsLastModified) {
> >- ivy = new Ivy();
> >+ IvySettings ivySettings = new IvySettings();
> >+ if (javaProject != null) {
> >+
>
> ivySettings.setBaseDir(javaProject.getProject().getLocation().toFile());
>
> >+ }
> > if (ivySettingsLastModified == -1) {
> > Message.info("\n\n");
> > } else {
> > Message.info("\n\nIVYDE: ivysettings has changed,
>
> configuring ivy again\n");
>
> The info message completely in lower case?
is there any worry about it ?
> Why just the two new lines when -1?
The two new lines are I think because we are probably starting a new resolve
session, so this need to be somehow visible.
And -1 means that the file has not been loaded yet, so there is no reloading
to log about.
Nicolas
>
>
> Jan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org