You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/08 12:28:21 UTC
[GitHub] [doris] liaoxin01 opened a new pull request, #10706: [feature-wip](unique-key-merge-on-write) add bloom filter index for primary key, DSIP-018[1.2]
liaoxin01 opened a new pull request, #10706:
URL: https://github.com/apache/doris/pull/10706
# Proposed changes
Add Bloom filter index for primary key. This patch is for step 1.2 in scheduling.
For the detail, see DSIP-018:https://cwiki.apache.org/confluence/display/DORIS/DSIP-018%3A+Support+Merge-On-Write+implementation+for+UNIQUE+KEY+data+model
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (Yes)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10706: [feature-wip](unique-key-merge-on-write) add bloom filter index for primary key, DSIP-018[1.2]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10706:
URL: https://github.com/apache/doris/pull/10706#issuecomment-1179494625
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #10706: [feature-wip](unique-key-merge-on-write) add bloom filter index for primary key, DSIP-018[1.2]
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #10706:
URL: https://github.com/apache/doris/pull/10706#discussion_r917232884
##########
be/src/olap/primary_key_index.cpp:
##########
@@ -30,12 +30,17 @@ Status PrimaryKeyIndexBuilder::init() {
options.encoding = segment_v2::EncodingInfo::get_default_encoding(type_info, true);
// TODO(liaoxin) test to confirm whether it needs to be compressed
options.compression = segment_v2::NO_COMPRESSION; // currently not compressed
- _index_builder.reset(new segment_v2::IndexedColumnWriter(options, type_info, _file_writer));
- return _index_builder->init();
+ _primary_key_index_builder.reset(
+ new segment_v2::IndexedColumnWriter(options, type_info, _file_writer));
+ RETURN_IF_ERROR(_primary_key_index_builder->init());
+
+ return segment_v2::BloomFilterIndexWriter::create(segment_v2::BloomFilterOptions(), type_info,
+ &_bloom_filter_index_builder);
}
Status PrimaryKeyIndexBuilder::add_item(const Slice& key) {
- _index_builder->add(&key);
+ _primary_key_index_builder->add(&key);
Review Comment:
RETURN_IF_ERROR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on pull request #10706: [feature-wip](unique-key-merge-on-write) add bloom filter index for primary key, DSIP-018[1.2]
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on PR #10706:
URL: https://github.com/apache/doris/pull/10706#issuecomment-1180482126
@dataroaring could you help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #10706: [feature-wip](unique-key-merge-on-write) add bloom filter index for primary key, DSIP-018[1.2]
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #10706:
URL: https://github.com/apache/doris/pull/10706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org