You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/01 18:20:12 UTC
[PR] fix(acl): align ACL 2.0 binding type validation with the policy service [rocketmq-dashboard]
yyqdbngt opened a new pull request, #2927:
URL: https://github.com/apache/rocketmq-dashboard/pull/2927
## Summary
- align `Acl2PolicyContext.validate()` with the operational `AclService#validateAcl2Policy` binding-type vocabulary
- require a non-blank `boundType` and accept `TOPIC`, `GROUP`, `*`, `USER`, `SERVICE_ACCOUNT` case-insensitively
- add regression coverage for the model validator's accepted and rejected binding types
## Why
Two validators for the same ACL 2.0 policy concept disagreed: the model validator only accepted exactly-cased `USER`/`GROUP`/`SERVICE_ACCOUNT` and silently let a null `boundType` through, while the service validator (covered by `AclServiceTest`) requires a non-blank type and accepts the wider `TOPIC`/`GROUP`/`*`/`USER`/`SERVICE_ACCOUNT` set case-insensitively. A policy the service accepts (`"topic"`, `"user"`) failed the model's `validate()` with a misleading exception, and a null binding type passed the model but failed the service.
## Testing
- `cd server && mvn -q -Dtest=Acl2PolicyContextTest test` — 11 tests pass (new class)
- `cd server && mvn -q -Dtest=AclServiceTest test` — all tests pass (regression for the aligned vocabulary)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(acl): align ACL 2.0 binding type validation with the policy service [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2927: fix(acl): align ACL 2.0 binding type validation with the policy service
URL: https://github.com/apache/rocketmq-dashboard/pull/2927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(acl): align ACL 2.0 binding type validation with the policy service [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2927:
URL: https://github.com/apache/rocketmq-dashboard/pull/2927#issuecomment-5593755874
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org