[GitHub] [systemds] vanessavieira commented on a change in pull request #1189: [DIA] Km and Cox functions

[GitBox <gi...@apache.org>]

vanessavieira commented on a change in pull request #1189:
URL: https://github.com/apache/systemds/pull/1189#discussion_r585022263



##########
File path: src/test/java/org/apache/sysds/test/functions/builtin/BuiltinCoxTest.java
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.sysds.test.functions.builtin;
+
+import org.apache.sysds.common.Types;
+import org.apache.sysds.test.AutomatedTestBase;
+import org.apache.sysds.test.TestConfiguration;
+import org.junit.Test;
+
+public class BuiltinCoxTest extends AutomatedTestBase
+{
+	private final static String TEST_NAME = "cox";
+	private final static String TEST_DIR = "functions/builtin/";
+	private final static String TEST_CLASS_DIR = TEST_DIR + BuiltinCoxTest.class.getSimpleName() + "/";
+
+	@Override
+	public void setUp() {
+		addTestConfiguration(TEST_NAME, new TestConfiguration(TEST_CLASS_DIR, TEST_NAME,new String[]{"B"}));
+	}
+
+	@Test
+	public void testFunction() {
+		runCoxTest(50, 2.0, 1.5, 0.8, 100, 0.05, 1.0,0.000001, 100, 0);
+	}
+	
+	public void runCoxTest(int numRecords, double scaleWeibull, double shapeWeibull, double prob,
+						   int numFeatures, double sparsity, double alpha, double tol, int moi, int mii) {
+		Types.ExecMode platformOld = setExecMode(Types.ExecMode.SINGLE_NODE);
+		loadTestConfiguration(getTestConfiguration(TEST_NAME));
+		String HOME = SCRIPT_DIR + TEST_DIR;
+		fullDMLScriptName = HOME + TEST_NAME + ".dml";
+
+		programArgs = new String[]{
+				"-nvargs", "M=" + output("M"), "S=" + output("S"), "T=" + output("T"), "COV=" + output("COV"),
+				"RT=" + output("RT"), "XO=" + output("XO"), "n=" + numRecords, "l=" + scaleWeibull,
+				"v=" + shapeWeibull, "p=" + prob, "m=" + numFeatures, "sp=" + sparsity,
+				"alpha=" + alpha, "tol=" + tol, "moi=" + moi, "mii=" + mii};
+
+		runTest(true, false, null, -1);

Review comment:
       I see and I agree I should be testing the output. The problem I faced with testing is how to know the output I am expecting. First I needed to know how the input should look like and for that, I used parts of the data generation for survival analysis script (https://github.com/apache/systemds/blob/master/scripts/datagen/genRandData4SurvAnalysis.dml) but with that I don't really have a way of knowing what should be the output. Do you think I should create an R script that accepts the same input and then checks if the output returned is the same? I'm not sure how much trouble that would be or if there's already both algorithms implemented in R 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org