You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/09 05:39:50 UTC
[I] fix: make message ID queries without a topic actionable [rocketmq-dashboard]
Aias00 opened a new issue, #1292:
URL: https://github.com/apache/rocketmq-dashboard/issues/1292
## Problem\n\nThe message query endpoint accepts an optional for message-ID queries, but the current provider only resolves a message when the topic is supplied. A just-sent message queried through returns a successful empty list instead of an actionable result.\n\nThis makes the message-ID query flow appear to work while silently dropping the result. The behavior was reproduced against a local NameServer/Broker with both the send response's message ID and offset message ID.\n\n## Scope\n\n- Define an explicit, actionable behavior for message-ID queries when no topic is supplied.\n- Avoid returning an indistinguishable successful empty result for an unsupported lookup shape.\n- Preserve topic-scoped message-ID lookup.\n\n## Acceptance criteria\n\n- A message-ID query without a topic either resolves the message through a supported path or returns a structured validation error explaining that a topic is required.\n- Topic-scoped message-ID lookup continues to return the sent messa
ge.\n- Add regression coverage for both paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] fix: make message ID queries without a topic actionable [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on issue #1292:
URL: https://github.com/apache/rocketmq-dashboard/issues/1292#issuecomment-5307205174
Resolved on the current `rocketmq-studio` baseline. `MessageService#validateTopicQueryWindow` now rejects a message-ID query without `topic` with a structured HTTP 400 (`topic is required when msgId is specified`) before it reaches the provider, and `MessageServiceTest#rejectsMessageIdQueryWithoutTopicBeforeCallingProvider` covers the regression. This is the explicit validation behavior permitted by the acceptance criteria. Closing as completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] fix: make message ID queries without a topic actionable [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #1292: fix: make message ID queries without a topic actionable
URL: https://github.com/apache/rocketmq-dashboard/issues/1292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] fix: make message ID queries without a topic actionable [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #1292:
URL: https://github.com/apache/rocketmq-dashboard/issues/1292#issuecomment-5230087139
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
The reported issue has been verified against the current codebase.
**Root Cause:** The `viewMessage` endpoint declares `topic` as optional (`@RequestParam(required = false)` in `MessageController.java`), but the provider implementation `MQAdminExtImpl.viewMessage(String topic, String msgId)` cannot resolve a message without it. It calls `getTopicClusterList(topic)` which requires a valid topic to determine cluster routing. When `topic` is null, the cluster lookup fails and the topic-less query cannot route to a broker. The method never falls back to the offsetId-based topic-less `viewMessage(msgId)` overload that `DefaultMQAdminExt` supports.
**Impact:** Message-ID queries without a topic silently return an empty list instead of an actionable result, making the message lookup flow appear to work while dropping results.
**Severity:** medium — A functional/UX gap, not a crash or security issue. Workaround exists (supply the topic).
**Affected Files:**
- `MessageController.java` (optional `topic` parameter)
- `MessageServiceImpl.java` (`viewMessage` method)
- `MQAdminExtImpl.java` (custom `viewMessage` that requires a topic)
**Suggested Fix:** In `MQAdminExtImpl.viewMessage`, when `topic` is null/blank, fall back to the topic-less overload `MQAdminInstance.threadLocalMQAdminExt().viewMessage(msgId)`, which resolves the broker and physical offset directly from the offsetId encoded in the `msgId`.
An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by github-manager*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] fix: make message ID queries without a topic actionable [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #1292:
URL: https://github.com/apache/rocketmq-dashboard/issues/1292#issuecomment-5231199006
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
The reported issue has been analyzed.
**Root Cause:** The message query endpoint accepts an optional `topic` for message-ID queries, but the provider only resolves a message when the topic is supplied. A message-ID query without a topic returns a successful empty list, silently dropping the result.
**Impact:** The message-ID query flow appears to work while silently failing, making it impossible to query sent messages by ID alone.
**Severity:** Medium — affects the message query UX in the dashboard.
**Suggested Fix:** Either resolve the message through a topic-less lookup path or return a structured validation error explaining that a topic is required.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org