You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/27 06:23:28 UTC

[GitHub] [spark] zhengruifeng commented on a diff in pull request #38393: [SPARK-40915][CONNECT] Improve `on` in Join in Python client

zhengruifeng commented on code in PR #38393:
URL: https://github.com/apache/spark/pull/38393#discussion_r1006443809


##########
python/pyspark/sql/connect/plan.py:
##########
@@ -537,7 +537,7 @@ def __init__(
         self,
         left: Optional["LogicalPlan"],
         right: "LogicalPlan",
-        on: "ColumnOrString",
+        on: Optional[Union[str, List[str], ColumnRef]],

Review Comment:
   should not be incompatible change, they are just used for static checking



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org