You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/14 02:59:14 UTC
[GitHub] [iceberg] kbendick commented on a change in pull request #3732: Docs: Add stream-from-timestamp in spark-configuration.md
kbendick commented on a change in pull request #3732:
URL: https://github.com/apache/iceberg/pull/3732#discussion_r768278716
##########
File path: site/docs/spark-configuration.md
##########
@@ -155,6 +155,7 @@ spark.read
| file-open-cost | As per table property | Overrides this table's read.split.open-file-cost |
| vectorization-enabled | As per table property | Overrides this table's read.parquet.vectorization.enabled |
| batch-size | As per table property | Overrides this table's read.parquet.vectorization.batch-size |
+| stream-from-timestamp | Long.MIN_VALUE | Timestamp in milliseconds; start a stream from the snapshot that occurs after this timestamp. |
Review comment:
Nit: Could you reword the description to be a bit more clear about which snapshot is started from? That was a source of confusion for a while for me.
Maybe `Timestamp in milliseconds, start streaming this table from the first snapshot that occurs strictly after this timestamp`?
It's a minor change, but it took me a while to be sure which snapshot was being referred to after being explained it, so I think it might help others as well to be more sure of what we mean.
##########
File path: site/docs/spark-configuration.md
##########
@@ -155,6 +155,7 @@ spark.read
| file-open-cost | As per table property | Overrides this table's read.split.open-file-cost |
| vectorization-enabled | As per table property | Overrides this table's read.parquet.vectorization.enabled |
| batch-size | As per table property | Overrides this table's read.parquet.vectorization.batch-size |
+| stream-from-timestamp | Long.MIN_VALUE | Timestamp in milliseconds; start a stream from the snapshot that occurs after this timestamp. |
Review comment:
Nit: Also, the rest of the descriptions don't seem to end in periods. I'm not sure if that's because they end with configuration keys, but if other sentences in the same column don't end with periods can you remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org