You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/22 03:22:38 UTC

[GitHub] [incubator-inlong-website] pocozh opened a new pull request #314: [INLONG-3288][Audit] Support TubMQ for website

pocozh opened a new pull request #314:
URL: https://github.com/apache/incubator-inlong-website/pull/314


   Fixes https://github.com/apache/incubator-inlong/issues/3288
   
   where *XYZ* should be replaced by the actual issue number.
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong-website] dockerzhang merged pull request #314: [INLONG-3288][Audit] Support TubMQ for website

Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #314:
URL: https://github.com/apache/incubator-inlong-website/pull/314


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong-website] dockerzhang commented on a change in pull request #314: [INLONG-3288][Audit] Support TubMQ for website

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #314:
URL: https://github.com/apache/incubator-inlong-website/pull/314#discussion_r831816868



##########
File path: docs/modules/audit/quick_start.md
##########
@@ -5,33 +5,58 @@ title: Deployment
 All deploying files at `inlong-audit` directory, if you use MySQL to store audit data, you need to first create the database through `sql/apache_inlong_audit.sql`.
 
 ## Audit Proxy
-### Configure Pulsar
-The configuration file  is `conf/audit.conf`. 
+### Configure MessageQueue
+You can choose Apache Pulsar or InLong TubeMQ as your MessageQueue service:
+
+- If using Pulsar, the configuration file is `conf/audit-proxy-pulsar.conf`
+

Review comment:
       add an explanation about how to config the pulsar address.

##########
File path: docs/modules/audit/quick_start.md
##########
@@ -5,33 +5,58 @@ title: Deployment
 All deploying files at `inlong-audit` directory, if you use MySQL to store audit data, you need to first create the database through `sql/apache_inlong_audit.sql`.
 
 ## Audit Proxy
-### Configure Pulsar
-The configuration file  is `conf/audit.conf`. 
+### Configure MessageQueue
+You can choose Apache Pulsar or InLong TubeMQ as your MessageQueue service:
+
+- If using Pulsar, the configuration file is `conf/audit-proxy-pulsar.conf`
+
 ```Shell
 agent1.sources.tcp-source.host = 0.0.0.0
-agent1.sources.tcp-source.port = 46801
+agent1.sources.tcp-source.port = 10081
 agent1.sinks.pulsar-sink-msg1.pulsar_server_url= pulsar://PULSAR_BROKER_LIST
 agent1.sinks.pulsar-sink-msg1.topic = persistent://public/default/inlong-audit
 agent1.sinks.pulsar-sink-msg2.pulsar_server_url = pulsar://PULSAR_BROKER_LIST
 agent1.sinks.pulsar-sink-msg2.topic = persistent://public/default/inlong-audit
 ```
 
+- If using TubeMQ, the configuration file is `conf/audit-proxy-tube.conf`
+
+```Shell
+agent1.sources.tcp-source.host = 0.0.0.0
+agent1.sources.tcp-source.port = 10081
+agent1.sinks.tube-sink-msg1.master-host-port-list = TUBE_LIST
+agent1.sinks.tube-sink-msg1.topic = inlong-audit
+agent1.sinks.tube-sink-msg2.master-host-port-list = TUBE_LIST
+agent1.sinks.tube-sink-msg2.topic = inlong-audit
+```
+
 ### Start
 ```Shell
-sh ./bin/proxy-start.sh
+#By default, pulsar is used as the MessageQueue, and the audit-proxy-pulsar.conf configuration file is loaded.
+sh ./bin/proxy-start.sh [pulsar|tube]
 ```
 
 ## Audit Store
 ### Configure
 The configuration file  is `conf/application.properties`. 

Review comment:
       add an explanation about how to config the pulsar or tubemq address.

##########
File path: docs/modules/audit/quick_start.md
##########
@@ -5,33 +5,58 @@ title: Deployment
 All deploying files at `inlong-audit` directory, if you use MySQL to store audit data, you need to first create the database through `sql/apache_inlong_audit.sql`.
 
 ## Audit Proxy
-### Configure Pulsar
-The configuration file  is `conf/audit.conf`. 
+### Configure MessageQueue
+You can choose Apache Pulsar or InLong TubeMQ as your MessageQueue service:
+
+- If using Pulsar, the configuration file is `conf/audit-proxy-pulsar.conf`
+
 ```Shell
 agent1.sources.tcp-source.host = 0.0.0.0
-agent1.sources.tcp-source.port = 46801
+agent1.sources.tcp-source.port = 10081
 agent1.sinks.pulsar-sink-msg1.pulsar_server_url= pulsar://PULSAR_BROKER_LIST
 agent1.sinks.pulsar-sink-msg1.topic = persistent://public/default/inlong-audit
 agent1.sinks.pulsar-sink-msg2.pulsar_server_url = pulsar://PULSAR_BROKER_LIST
 agent1.sinks.pulsar-sink-msg2.topic = persistent://public/default/inlong-audit
 ```
 
+- If using TubeMQ, the configuration file is `conf/audit-proxy-tube.conf`
+

Review comment:
       ditto, add an explanation about how to config the tube address.

##########
File path: docs/modules/audit/overview.md
##########
@@ -12,7 +12,7 @@ The transmission status of each module, and whether the data stream is lost or r
 ## Architecture
 ![](img/audit_architecture.png)
 1. The audit SDK is nested in the service that needs to be audited, audits the service, and sends the audit result to the audit access layer
-2. The audit proxy writes audit data to MQ (kafak or pulsar)
+2. The audit proxy writes audit data to MQ (kafka, pulsar or TubeMQ)

Review comment:
       `Kafka` is not supported, please remove it. otherwise, `pulsar` -> `Pulsar`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org