[jira] [Updated] (DERBY-6596) LUCENESUPPORT routines should check for NULL arguments

["Rick Hillegas (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-6596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rick Hillegas updated DERBY-6596:
---------------------------------

    Attachment: derby-6596-01-aa-checkNotNull.diff

Attaching derby-6596-01-aa-checkNotNull.diff. This patch raises exceptions if various args to the lucene support routines are null. The lucene tests pass for me using this patch.


Touches the following files:

M       java/engine/org/apache/derby/loc/messages.xml
M       java/optional/org/apache/derby/optional/lucene/LuceneQueryVTI.java
M       java/optional/org/apache/derby/optional/lucene/LuceneSupport.java
M       java/shared/org/apache/derby/shared/common/reference/SQLState.java
M       java/testing/org/apache/derbyTesting/functionTests/tests/lang/LuceneSupportPermsTest.java


> LUCENESUPPORT routines should check for NULL arguments
> ------------------------------------------------------
>
>                 Key: DERBY-6596
>                 URL: https://issues.apache.org/jira/browse/DERBY-6596
>             Project: Derby
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Rick Hillegas
>            Priority: Minor
>         Attachments: derby-6596-01-aa-checkNotNull.diff
>
>
> When the LUCENESUPPORT routines are called with argument value NULL where a NULL is not allowed, they fail with NullPointerExceptions. Example:
> ij> call lucenesupport.createindex('app', 't', null, null);
> ERROR 38000: The exception 'java.lang.NullPointerException' was thrown while evaluating an expression.
> ERROR XJ001: Java exception: ': java.lang.NullPointerException'.
> Here, the third argument (the column name) cannot be NULL. It would be nicer if it raised an error that said that the argument couldn't be NULL, since a NullPointerException looks more like an internal error.



--
This message was sent by Atlassian JIRA
(v6.2#6252)