You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/07/07 23:07:58 UTC
[Impala-CR](cdh5-trunk) IMPALA-3839: Fix race condition in impala cluster.py
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3592
Change subject: IMPALA-3839: Fix race condition in impala_cluster.py
......................................................................
IMPALA-3839: Fix race condition in impala_cluster.py
Accesses to properties of Process objects from psutil hit the operating
system, at least under Linux. Therefore any access can throw
NoSuchProcess if the underlying process has already terminated. The fix
extends the try/except block to all such accesses.
To ensure that this change does not introduce a regression I ran
test_breakpad.py, which exercises this code. I also ran
test_breakpad.py:test_sigusr1_writes_minidump() in a loop for about 40
iterations with the changes from https://gerrit.cloudera.org/#/c/3312/6,
which made me discover this issue in the first place.
Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
---
M tests/common/impala_cluster.py
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/92/3592/1
--
To view, visit http://gerrit.cloudera.org:8080/3592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3839: Fix race condition in impala cluster.py
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello David Knupp, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3592
to look at the new patch set (#2).
Change subject: IMPALA-3839: Fix race condition in impala_cluster.py
......................................................................
IMPALA-3839: Fix race condition in impala_cluster.py
Accesses to properties of Process objects from psutil hit the operating
system, at least under Linux. Therefore any access can throw
NoSuchProcess if the underlying process has already terminated. The fix
extends the try/except block to all such accesses.
To ensure that this change does not introduce a regression I ran
test_breakpad.py, which exercises this code. I also ran
test_breakpad.py:test_sigusr1_writes_minidump() in a loop for about 40
iterations with the changes from https://gerrit.cloudera.org/#/c/3312/6,
which made me discover this issue in the first place.
Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
---
M tests/common/impala_cluster.py
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/92/3592/2
--
To view, visit http://gerrit.cloudera.org:8080/3592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3839: Fix race condition in impala cluster.py
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-3839: Fix race condition in impala_cluster.py
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Thanks for the reviews. I addressed them in PS. +2 from Tim and David.
http://gerrit.cloudera.org:8080/#/c/3592/1/tests/common/impala_cluster.py
File tests/common/impala_cluster.py:
Line 99: try:
> It would be kind of nice to share this with start-impala-cluster.py but I d
They don't share any code at the moment, start-impala-cluster.py looks like it does everything by itself. It's probably better to refactor it in a subsequent change. I opened IMPALA-3846 for the refactoring, David, can you triage that?
PS1, Line 110: >=1
> missing space
Done
--
To view, visit http://gerrit.cloudera.org:8080/3592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3839: Fix race condition in impala cluster.py
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged.
Change subject: IMPALA-3839: Fix race condition in impala_cluster.py
......................................................................
IMPALA-3839: Fix race condition in impala_cluster.py
Accesses to properties of Process objects from psutil hit the operating
system, at least under Linux. Therefore any access can throw
NoSuchProcess if the underlying process has already terminated. The fix
extends the try/except block to all such accesses.
To ensure that this change does not introduce a regression I ran
test_breakpad.py, which exercises this code. I also ran
test_breakpad.py:test_sigusr1_writes_minidump() in a loop for about 40
iterations with the changes from https://gerrit.cloudera.org/#/c/3312/6,
which made me discover this issue in the first place.
Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
Reviewed-on: http://gerrit.cloudera.org:8080/3592
Tested-by: Internal Jenkins
Reviewed-by: Lars Volker <lv...@cloudera.com>
---
M tests/common/impala_cluster.py
1 file changed, 13 insertions(+), 13 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3839: Fix race condition in impala cluster.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-3839: Fix race condition in impala_cluster.py
......................................................................
Patch Set 1: Code-Review+2
This looks like a reasonable change to me.
--
To view, visit http://gerrit.cloudera.org:8080/3592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3839: Fix race condition in impala cluster.py
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3839: Fix race condition in impala_cluster.py
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3592/1/tests/common/impala_cluster.py
File tests/common/impala_cluster.py:
Line 99: try:
It would be kind of nice to share this with start-impala-cluster.py but I don't know if there's a logical place to share python code between these two places.
PS1, Line 110: >=1
missing space
--
To view, visit http://gerrit.cloudera.org:8080/3592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3839: Fix race condition in impala cluster.py
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3839: Fix race condition in impala_cluster.py
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3839: Fix race condition in impala cluster.py
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-3839: Fix race condition in impala_cluster.py
......................................................................
Patch Set 2: Code-Review+2
Carrying forward +2 from Tim and David
--
To view, visit http://gerrit.cloudera.org:8080/3592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No