You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Mikhail Khludnev <mk...@griddynamics.com> on 2012/02/24 16:49:15 UTC

customization for SolrRequestParsers

Hello,

I see that some sort of customization was expected for SolrRequestParsers.
http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java?view=markup

line
 97 // I don't see a need to have this publicly configured just yet
and
 111 // TODO -- in the future, we could pick a different parser based on
the request

I need to plug some code which will parse request and add additional stuff
iinto req.context. I'd be happy to contribute it, but want to know what was
an intention.

Thanks in advance

-- 
Sincerely yours
Mikhail Khludnev
Lucid Certified
Apache Lucene/Solr Developer
Grid Dynamics

<http://www.griddynamics.com>
 <mk...@griddynamics.com>

Re: customization for SolrRequestParsers

Posted by Ryan McKinley <ry...@gmail.com>.
I don't recall exactly... but I think it was just an open suggestion that
we *could* use a different parser.

Since that comment was added (5 years ago?) i don't think it has come up...
 but if there is a good use case (and a patch) it may still be a good idea


On Fri, Feb 24, 2012 at 12:03 PM, Mikhail Khludnev <
mkhludnev@griddynamics.com> wrote:

> Ryan,
>
> I did it too, but just for curious, what was the idea of "pick a different
> parser based on request"?
>
>
> On Fri, Feb 24, 2012 at 11:06 PM, Ryan McKinley <ry...@gmail.com> wrote:
>
>> I don't know exactly what you are trying to do... but you *may* be able
>> to do it by overriding SolrDispatchFilter#execute(...)
>>
>> In my app, we add authentication tokens to the request context there.
>>
>>
>>
>> On Fri, Feb 24, 2012 at 7:49 AM, Mikhail Khludnev <
>> mkhludnev@griddynamics.com> wrote:
>>
>>> Hello,
>>>
>>> I see that some sort of customization was expected
>>> for SolrRequestParsers.
>>> http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java?view=markup
>>>
>>> line
>>>  97 // I don't see a need to have this publicly configured just yet
>>> and
>>>  111 // TODO -- in the future, we could pick a different parser based
>>> on the request
>>>
>>> I need to plug some code which will parse request and add additional
>>> stuff iinto req.context. I'd be happy to contribute it, but want to know
>>> what was an intention.
>>>
>>> Thanks in advance
>>>
>>> --
>>> Sincerely yours
>>> Mikhail Khludnev
>>> Lucid Certified
>>> Apache Lucene/Solr Developer
>>> Grid Dynamics
>>>
>>>  <http://www.griddynamics.com>
>>>  <mk...@griddynamics.com>
>>>
>>>
>>
>
>
> --
> Sincerely yours
> Mikhail Khludnev
> Lucid Certified
> Apache Lucene/Solr Developer
> Grid Dynamics
>
> <http://www.griddynamics.com>
>  <mk...@griddynamics.com>
>
>

Re: customization for SolrRequestParsers

Posted by Mikhail Khludnev <mk...@griddynamics.com>.
Ryan,

I did it too, but just for curious, what was the idea of "pick a different
parser based on request"?

On Fri, Feb 24, 2012 at 11:06 PM, Ryan McKinley <ry...@gmail.com> wrote:

> I don't know exactly what you are trying to do... but you *may* be able to
> do it by overriding SolrDispatchFilter#execute(...)
>
> In my app, we add authentication tokens to the request context there.
>
>
>
> On Fri, Feb 24, 2012 at 7:49 AM, Mikhail Khludnev <
> mkhludnev@griddynamics.com> wrote:
>
>> Hello,
>>
>> I see that some sort of customization was expected
>> for SolrRequestParsers.
>> http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java?view=markup
>>
>> line
>>  97 // I don't see a need to have this publicly configured just yet
>> and
>>  111 // TODO -- in the future, we could pick a different parser based on
>> the request
>>
>> I need to plug some code which will parse request and add additional
>> stuff iinto req.context. I'd be happy to contribute it, but want to know
>> what was an intention.
>>
>> Thanks in advance
>>
>> --
>> Sincerely yours
>> Mikhail Khludnev
>> Lucid Certified
>> Apache Lucene/Solr Developer
>> Grid Dynamics
>>
>>  <http://www.griddynamics.com>
>>  <mk...@griddynamics.com>
>>
>>
>


-- 
Sincerely yours
Mikhail Khludnev
Lucid Certified
Apache Lucene/Solr Developer
Grid Dynamics

<http://www.griddynamics.com>
 <mk...@griddynamics.com>

Re: customization for SolrRequestParsers

Posted by Ryan McKinley <ry...@gmail.com>.
I don't know exactly what you are trying to do... but you *may* be able to
do it by overriding SolrDispatchFilter#execute(...)

In my app, we add authentication tokens to the request context there.



On Fri, Feb 24, 2012 at 7:49 AM, Mikhail Khludnev <
mkhludnev@griddynamics.com> wrote:

> Hello,
>
> I see that some sort of customization was expected for SolrRequestParsers.
> http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java?view=markup
>
> line
>  97 // I don't see a need to have this publicly configured just yet
> and
>  111 // TODO -- in the future, we could pick a different parser based on
> the request
>
> I need to plug some code which will parse request and add additional stuff
> iinto req.context. I'd be happy to contribute it, but want to know what was
> an intention.
>
> Thanks in advance
>
> --
> Sincerely yours
> Mikhail Khludnev
> Lucid Certified
> Apache Lucene/Solr Developer
> Grid Dynamics
>
> <http://www.griddynamics.com>
>  <mk...@griddynamics.com>
>
>