[GitHub] [spark] tgravescs commented on a change in pull request #33873: [SPARK-36624][YARN] In yarn client mode, when ApplicationMaster failed with KILLED/FAILED, driver should exit with code not 0

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #33873:
URL: https://github.com/apache/spark/pull/33873#discussion_r715639393



##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala
##########
@@ -52,6 +52,14 @@ package object config extends Logging {
       .timeConf(TimeUnit.MILLISECONDS)
       .createOptional
 
+  private[spark] val AM_CLIENT_MODE_EXIT_DIRECTLY =
+    ConfigBuilder("spark.yarn.am.clientModeExitDirectly")
+      .doc("When ture, if YarnClientSchedulerBackend.MonitorThread got report with " +

Review comment:
       true is misspelled, perhaps rename to ClientModeExitOnError, I don't think user case about MonitorThread, I think we should state this more that it will system exit, but note that if this is true can called from another application it  will terminate the parent application as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org