You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2022/09/01 15:04:09 UTC
[plc4x] branch develop updated: refactor(plc4go): remove unneeded methods
This is an automated email from the ASF dual-hosted git repository.
sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git
The following commit(s) were added to refs/heads/develop by this push:
new 7ac5ab603 refactor(plc4go): remove unneeded methods
7ac5ab603 is described below
commit 7ac5ab6030f50b6a7ce6a3ec98efc7a211f757e9
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Thu Sep 1 17:04:02 2022 +0200
refactor(plc4go): remove unneeded methods
---
plc4go/internal/cbus/SubscriptionEvent.go | 4 ----
plc4go/internal/knxnetip/SubscriptionEvent.go | 4 ----
plc4go/pkg/api/model/plc_subscription.go | 1 -
3 files changed, 9 deletions(-)
diff --git a/plc4go/internal/cbus/SubscriptionEvent.go b/plc4go/internal/cbus/SubscriptionEvent.go
index 17d3027c3..b72238cea 100644
--- a/plc4go/internal/cbus/SubscriptionEvent.go
+++ b/plc4go/internal/cbus/SubscriptionEvent.go
@@ -40,10 +40,6 @@ func NewSubscriptionEvent(fields map[string]apiModel.PlcField, types map[string]
}
}
-func (m SubscriptionEvent) GetRequest() apiModel.PlcSubscriptionRequest {
- panic("implement me")
-}
-
func (m SubscriptionEvent) GetAddress(name string) string {
return m.address[name]
}
diff --git a/plc4go/internal/knxnetip/SubscriptionEvent.go b/plc4go/internal/knxnetip/SubscriptionEvent.go
index d9a8c42f9..159302922 100644
--- a/plc4go/internal/knxnetip/SubscriptionEvent.go
+++ b/plc4go/internal/knxnetip/SubscriptionEvent.go
@@ -42,10 +42,6 @@ func NewSubscriptionEvent(fields map[string]apiModel.PlcField, types map[string]
}
}
-func (m SubscriptionEvent) GetRequest() apiModel.PlcSubscriptionRequest {
- panic("implement me")
-}
-
// GetAddress Decode the binary data in the address according to the field requested
func (m SubscriptionEvent) GetAddress(name string) string {
rawAddress := m.addresses[name]
diff --git a/plc4go/pkg/api/model/plc_subscription.go b/plc4go/pkg/api/model/plc_subscription.go
index cda36113a..b981c9924 100644
--- a/plc4go/pkg/api/model/plc_subscription.go
+++ b/plc4go/pkg/api/model/plc_subscription.go
@@ -27,7 +27,6 @@ import (
type PlcSubscriptionEvent interface {
PlcResponse
- GetRequest() PlcSubscriptionRequest
GetFieldNames() []string
GetResponseCode(name string) PlcResponseCode
GetAddress(name string) string