[GitHub] [trafficcontrol] rob05c commented on issue #4145: Add TO API Routing Blacklist via cdn.conf

[GitBox <gi...@apache.org>]

rob05c commented on issue #4145: Add TO API Routing Blacklist via cdn.conf
URL: https://github.com/apache/trafficcontrol/pull/4145#issuecomment-558268628
 
 
   >Hrm, is there an alternative to integers here? It looks like we're exposing internal structure data in a config file.
   
   Hm, I see Chris's point here, numbers seem a bit more difficult for people to use. But I also see your point on the list about regexes being a pain.
   
   Question: is there a reason the route ID needs to be a number? What if every Route had a "Route ID" that was an arbitrary string, e.g. `get-cachegroups`?
   
   ```
   		{1.1, `get-cachegroups`, http.MethodGet, `cachegroups/{id}$`, api.ReadHandler(&cachegroup.TOCacheGroup{}), auth.PrivLevelReadOnly, Authenticated, nil, noPerlBypass},
   
   Would it be difficult to change the existing code to that?
   
   If not, is there an advantage to numbers over that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services